Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python3.4 from AppVeyor, CircleCI and Travis #535

Merged
merged 3 commits into from Apr 8, 2020
Merged

Conversation

amueller
Copy link
Owner

No description provided.

@amueller
Copy link
Owner Author

@jcfr do you know what's happening with circle? Seems related to scikit-ci and pytest. I have no idea what's happening there.

@jcfr
Copy link
Collaborator

jcfr commented Apr 8, 2020

The issue reported on CircleCI is due a regression in pytest. See Teemu/pytest-sugar#187

The regression was introduced in pytest 5.4.0, and then later fixed in 5.4.1. See Teemu/pytest-sugar#187 and https://github.com/pytest-dev/pytest/releases/tag/5.4.1

Update: It is fixed in pytest master but not yet included in a new pytest release. See pytest-dev/pytest#6986

For future reference, here is the error copied from CircleCI:

[scikit-ci] Executing: pytest
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/opt/python/cp35-cp35m/lib/python3.5/site-packages/_pytest/main.py", line 187, in wrap_session
INTERNALERROR>     config._do_configure()
INTERNALERROR>   File "/opt/python/cp35-cp35m/lib/python3.5/site-packages/_pytest/config/__init__.py", line 820, in _do_configure
INTERNALERROR>     self.hook.pytest_configure.call_historic(kwargs=dict(config=self))
INTERNALERROR>   File "/opt/python/cp35-cp35m/lib/python3.5/site-packages/pluggy/hooks.py", line 308, in call_historic
INTERNALERROR>     res = self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR>   File "/opt/python/cp35-cp35m/lib/python3.5/site-packages/pluggy/manager.py", line 93, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR>   File "/opt/python/cp35-cp35m/lib/python3.5/site-packages/pluggy/manager.py", line 87, in <lambda>
INTERNALERROR>     firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
INTERNALERROR>   File "/opt/python/cp35-cp35m/lib/python3.5/site-packages/pluggy/callers.py", line 208, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/opt/python/cp35-cp35m/lib/python3.5/site-packages/pluggy/callers.py", line 80, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/opt/python/cp35-cp35m/lib/python3.5/site-packages/pluggy/callers.py", line 187, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/opt/python/cp35-cp35m/lib/python3.5/site-packages/pytest_sugar.py", line 176, in pytest_configure
INTERNALERROR>     sugar_reporter = SugarTerminalReporter(standard_reporter)
INTERNALERROR>   File "/opt/python/cp35-cp35m/lib/python3.5/site-packages/pytest_sugar.py", line 214, in __init__
INTERNALERROR>     self.writer = self._tw
INTERNALERROR> AttributeError: can't set attribute

@jcfr
Copy link
Collaborator

jcfr commented Apr 8, 2020

I will create a separate PR addressing the problem, once merged I will rebase this topic.

@amueller
Copy link
Owner Author

amueller commented Apr 8, 2020

Thanks for checking it out! I saw the failure but didn't expect it to be actually in pytest, I didn't check out pytest sugar. Thanks again!

jcfr added a commit to jcfr/word_cloud that referenced this pull request Apr 8, 2020
The version 5.4.0 of pytest introduced a regression preventing pytest-sugar
from working (see [1] and [2])

It has been fixed in pytest (see [3]) and waiting a new release of
pytest is published, this commit updates requirements.

[1] Teemu/pytest-sugar#187
[2] amueller#535 (comment)
[3] pytest-dev/pytest#6986
@jcfr jcfr changed the title remove python3.4 from travis remove python3.4 from AppVeyor, CircleCI and Travis Apr 8, 2020
@jcfr jcfr merged commit fe89bfd into master Apr 8, 2020
@jcfr jcfr deleted the remove_python34 branch April 8, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants