Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify PytestPluginManager._is_in_confcutdir #12007

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Clarify PytestPluginManager._is_in_confcutdir #12007

merged 2 commits into from
Feb 18, 2024

Commits on Feb 18, 2024

  1. Clarify PytestPluginManager._is_in_confcutdir 

    Follow up to pytest-dev#12006, let's put some comments clarifying `is_in_confcutdir` semantics, as this is not the first time someone misunderstands it.

Also removed an obsolete comment in `_loadconftestmodules`: we already set the `confcutdir` based on `rootdir`/`initfile` if not explicitly given.
    @nicoddemus
    nicoddemus committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    b85b386 View commit details
    Browse the repository at this point in the history

  2. Update src/_pytest/config/__init__.py 

    Co-authored-by: Ran Benita <ran@unusedvar.com>
    @nicoddemus @bluetech
    nicoddemus and bluetech committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    84bdd6f View commit details
    Browse the repository at this point in the history