Clarify PytestPluginManager._is_in_confcutdir #12007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to pytest-dev#12006, let's put some comments clarifying `is_in_confcutdir` semantics, as this is not the first time someone misunderstands it. Also removed an obsolete comment in `_loadconftestmodules`: we already set the `confcutdir` based on `rootdir`/`initfile` if not explicitly given.
nicoddemus
commented
Feb 18, 2024
| @@ -578,12 +578,18 @@ def _set_initial_conftests( | |||
| self._try_load_conftest(invocation_dir, importmode, rootpath) | |||
|
|
|||
| def _is_in_confcutdir(self, path: Path) -> bool: | |||
There was a problem hiding this comment.
How about renaming this to focus on the purpose of the method rather than the implementation detail?
Suggested change
| def _is_in_confcutdir(self, path: Path) -> bool: | |
| def _should_load_conftests_from(self, path: Path) -> bool: |
nicoddemus
commented
Feb 18, 2024
| @@ -609,9 +615,6 @@ def _loadconftestmodules( | |||
| if directory in self._dirpath2confmods: | |||
| return | |||
|
|
|||
| # XXX these days we may rather want to use config.rootpath | |||
There was a problem hiding this comment.
This comment is outdated, we always configure confcutdir nowadays:
pytest/src/_pytest/config/__init__.py
Lines 1334 to 1339 in 40011b8
bluetech
approved these changes
Feb 18, 2024
Co-authored-by: Ran Benita <ran@unusedvar.com>
flying-sheep
pushed a commit
to flying-sheep/pytest
that referenced
this pull request
Apr 9, 2024
Follow up to pytest-dev#12006, let's put some comments clarifying `is_in_confcutdir` semantics, as this is not the first time someone misunderstands it. Also removed an obsolete comment in `_loadconftestmodules`: we already set the `confcutdir` based on `rootdir`/`initfile` if not explicitly given. Co-authored-by: Ran Benita <ran@unusedvar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #12006, let's put some comments clarifying
is_in_confcutdirsemantics, as this is not the first time someone misunderstands it.Also removed an obsolete comment in
_loadconftestmodules: we already set theconfcutdirbased onrootdir/initfileif not explicitly given.