Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip teardown with --pdb for skipped class #10061

Closed
wants to merge 3 commits into from

Conversation

hugobuddel
Copy link

closes #10060


Thanks for submitting a PR, your contribution is really appreciated!

Here is a quick checklist that should be present in PRs.

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.
  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

If this change fixes an issue, please:

  • Add text like closes #XYZW to the PR description and/or commits (where XYZW is the issue number). See the github docs for more information.
  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Add yourself to AUTHORS in alphabetical order.

@hugobuddel hugobuddel changed the title Teardown pdb class Skip teardown with --pdb for skipped class Jun 21, 2022
@nicoddemus
Copy link
Member

nicoddemus commented Jun 26, 2022

Hi @hugobuddel,

I looked at the issue and opened #10081 without noticing this PR first, so sorry. 🤦‍♂️

However the implementation on my PR is simpler, so I prefer we use that.

Again sorry for not noticing this before, otherwise I would instead suggest changes here.

@hugobuddel
Copy link
Author

Hi @hugobuddel,

I looked at the issue and opened #10081 without noticing this PR first, so sorry. 🤦‍♂️

However the implementation on my PR is simpler, so I prefer we use that.

NP, thanks for fixing the bug @nicoddemus! Your solution is fine with me, so I'll close this one.

@hugobuddel hugobuddel closed this Jun 26, 2022
@nicoddemus
Copy link
Member

Thanks, and again sorry for wasting your time. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unittest.TestCase.tearDown executed for classes marked with unittest.skip when running --pdb
2 participants