Replace deprecated logging.warn with logging.warning #10064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! Wonder if we need a changelog entry for this? |
|
reopen cycled in the hope that pre-commit.ci works this time |
|
btw, no changelog needed, as this is a minor test cleanup thats practically not user-facing |
|
pre-commit.ci isn't running on other PRs either, for example #10061. The last pre-commit.ci run was on 2022-06-06: https://results.pre-commit.ci/repo/github/37489525 ping @asottile |
|
someone turned it off -- not really sure who -- https://results.pre-commit.ci/install/github/13658824 |
|
pre-commit.ci run |
|
I re-added it to pytest-dev/pytest |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
logging.warn(deprecated in Python 2.7, 2011) withlogging.warning(added in Python 2.3, 2003).