Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release needed to work with latest pytest-xdist #422

Closed
kbattocchi opened this issue Aug 14, 2020 · 9 comments
Closed

New release needed to work with latest pytest-xdist #422

kbattocchi opened this issue Aug 14, 2020 · 9 comments

Comments

@kbattocchi
Copy link

Summary

If I pip install the latest pytest-xdist and pytest-cov, then I will get failures when running pytest -n auto --cov=<my directory> because the latest released pytest-cov (2.10.0) is not compatible with pytest-xdist 2.0.0; this has been fixed by #412 but this PR hasn't made it into any release.

Versions

pytest-xdist 2.0.0
pytest-cov 2.10.0

ssbarnea added a commit to ansible/ansible-lint that referenced this issue Aug 14, 2020
Hotfix for todays release of xdist which does not work with latest pytest-cov
See pytest-dev/pytest-cov#422
ionelmc added a commit that referenced this issue Aug 14, 2020
@ionelmc
Copy link
Member

ionelmc commented Aug 14, 2020

I'll cut a release after CI passes.

@ssbarnea
Copy link
Member

@ionelmc Super, that is great. I may avoid the pining.

@nicoddemus
Copy link
Member

Thanks @ionelmc, thanks for the quick response!

ssbarnea added a commit to ansible/ansible-lint that referenced this issue Aug 14, 2020
- Move test requirements from tox.ini to a test extra
- Removes unused test requirements
- Pin-down incompatible pytest-xdist<2.0.0 due to
  pytest-dev/pytest-cov#422
- Bumps test requirements to decrease change of running outdated
  version while developing.
@ssbarnea
Copy link
Member

I see that CI is all green, mind to push the magic 2.10.1 tag?

@ionelmc
Copy link
Member

ionelmc commented Aug 14, 2020

2.10.1 is released.

@kbattocchi
Copy link
Author

Thanks for the quick response!

ssbarnea added a commit to ansible/ansible-lint that referenced this issue Aug 17, 2020
- Move test requirements from tox.ini to a test extra
- Removes unused test requirements
- Bumps test requirements to decrease change of running outdated
  version while developing, including avoidance of
  pytest-dev/pytest-cov#422
@shlomiken
Copy link

Hi
i had the original problem described here - and i upgraded to the 2.10.1 version (working with xdist 2.0.0)
now i get this error - what am i missing here ?

packages/xdist/workermanage.py", line 299, in sendcommand
17:36:59 INTERNALERROR>     self.channel.send((name, kwargs))
17:36:59 INTERNALERROR>   File "/home/centos/workspace/predictive-models-pull-request/rpclick-model/venv/lib/python3.6/site-packages/execnet/gateway_base.py", line 728, in send
17:36:59 INTERNALERROR>     raise IOError("cannot send to {!r}".format(self))
17:36:59 INTERNALERROR> OSError: cannot send to <Channel id=3 closed>

@ionelmc
Copy link
Member

ionelmc commented Aug 18, 2020

@shlomiken you might want to make a bug report to https://github.com/pytest-dev/pytest-xdist with more details to get the right people see it.

@shlomiken
Copy link

I was having older version of pytest , now when moved to 6.0 everything is working.
here are the final versions i can confirm working

pytest==6.0.1
pytest-cov==2.10.1
pytest-xdist==2.0.0

ssbarnea added a commit to ansible/ansible-lint that referenced this issue Aug 27, 2020
- Move test requirements from tox.ini to a test extra
- Removes unused test requirements
- Bumps test requirements to decrease change of running outdated
  version while developing, including avoidance of
  pytest-dev/pytest-cov#422
ngie-eign added a commit to ngie-eign/freebsd-ports that referenced this issue Mar 13, 2023
Summary:
This is required so py-pytest-cov is functional with newer versions of
py-pytest-xdist [1].

Backport patches from upstream commit to [selectively] add 3.11 support
to make some of the tests not fail when run with newer versions of
coverage.py [2].

While here, appease portlint by shifting where variables (`CONFLICTS`,
etc) are defined.

1. pytest-dev/pytest-cov#422
2. pytest-dev/pytest-cov#570

PR:	269360
Co-Authored-With:	Yuri Victorovich <yuri@freebsd.org>

Test Plan: `make test` passes with this change.

Reviewers: dbaio

Subscribers: mat, yuri

Differential Revision: https://reviews.freebsd.org/D39035
ngie-eign added a commit to ngie-eign/freebsd-ports that referenced this issue Mar 24, 2023
Summary:
This is required so py-pytest-cov is functional with newer versions of
py-pytest-xdist [1].

Backport patches from upstream commit to [selectively] add 3.11 support
to make some of the tests not fail when run with newer versions of
coverage.py [2].

While here, appease portlint by shifting where variables (`CONFLICTS`,
etc) are defined.

1. pytest-dev/pytest-cov#422
2. pytest-dev/pytest-cov#570

PR:	269360
Co-Authored-With:	Yuri Victorovich <yuri@freebsd.org>

Test Plan: `make test` passes with this change.

Reviewers: dbaio

Subscribers: mat, yuri

Differential Revision: https://reviews.freebsd.org/D39035
ngie-eign added a commit to ngie-eign/freebsd-ports that referenced this issue May 6, 2023
Summary:
This is required so py-pytest-cov is functional with newer versions of
py-pytest-xdist [1].

Backport patches from upstream commit to [selectively] add 3.11 support
to make some of the tests not fail when run with newer versions of
coverage.py [2].

While here, appease portlint by shifting where variables (`CONFLICTS`,
etc) are defined.

1. pytest-dev/pytest-cov#422
2. pytest-dev/pytest-cov#570

PR:	269360
Co-Authored-With:	Yuri Victorovich <yuri@freebsd.org>

Test Plan: `make test` passes with this change.

Reviewers: dbaio

Subscribers: mat, yuri

Differential Revision: https://reviews.freebsd.org/D39035
ngie-eign added a commit to ngie-eign/freebsd-ports that referenced this issue Jun 23, 2023
Summary:
This is required so py-pytest-cov is functional with newer versions of
py-pytest-xdist [1].

Backport patches from upstream commit to [selectively] add 3.11 support
to make some of the tests not fail when run with newer versions of
coverage.py [2].

While here, appease portlint by shifting where variables (`CONFLICTS`,
etc) are defined.

1. pytest-dev/pytest-cov#422
2. pytest-dev/pytest-cov#570

PR:	269360
Co-Authored-With:	Yuri Victorovich <yuri@freebsd.org>

Test Plan: `make test` passes with this change.

Reviewers: dbaio

Subscribers: mat, yuri

Differential Revision: https://reviews.freebsd.org/D39035
ngie-eign added a commit to ngie-eign/freebsd-ports that referenced this issue Jul 27, 2023
Summary:
This is required so py-pytest-cov is functional with newer versions of
py-pytest-xdist [1].

Backport patches from upstream commit to [selectively] add 3.11 support
to make some of the tests not fail when run with newer versions of
coverage.py [2].

While here, appease portlint by shifting where variables (`CONFLICTS`,
etc) are defined.

1. pytest-dev/pytest-cov#422
2. pytest-dev/pytest-cov#570

PR:	269360
Co-Authored-With:	Yuri Victorovich <yuri@freebsd.org>

Test Plan: `make test` passes with this change.

Reviewers: dbaio

Subscribers: mat, yuri

Differential Revision: https://reviews.freebsd.org/D39035
ngie-eign added a commit to ngie-eign/freebsd-ports that referenced this issue Aug 4, 2023
Summary:
This is required so py-pytest-cov is functional with newer versions of
py-pytest-xdist [1].

Backport patches from upstream commit to [selectively] add 3.11 support
to make some of the tests not fail when run with newer versions of
coverage.py [2].

While here, appease portlint by shifting where variables (`CONFLICTS`,
etc) are defined.

1. pytest-dev/pytest-cov#422
2. pytest-dev/pytest-cov#570

PR:	269360
Co-Authored-With:	Yuri Victorovich <yuri@freebsd.org>

Test Plan: `make test` passes with this change.

Reviewers: dbaio

Subscribers: mat, yuri

Differential Revision: https://reviews.freebsd.org/D39035
ngie-eign added a commit to ngie-eign/freebsd-ports that referenced this issue Aug 4, 2023
Summary:
This is required so py-pytest-cov is functional with newer versions of
py-pytest-xdist [1].

While here, appease portlint by shifting where variables (`CONFLICTS`,
etc) are defined.

1. pytest-dev/pytest-cov#422

PR:	269360
Co-Authored-With:	Yuri Victorovich <yuri@freebsd.org>

Test Plan: `make test` passes with this change.

Reviewers: dbaio

Subscribers: mat, yuri

Differential Revision: https://reviews.freebsd.org/D39035
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Aug 31, 2023
This is required so py-pytest-cov is functional with newer versions of
py-pytest-xdist [1].

While here, appease portlint by shifting where variables (`CONFLICTS`,
etc) are defined.

1. pytest-dev/pytest-cov#422

PR:	269360
Reviewed by:	yuri
Approved by:	dbaio (maintainer timeout; 5 months)
Co-Authored By:	Yuri Victorovich <yuri@freebsd.org>
Differential Revision: https://reviews.freebsd.org/D39035
ambroff pushed a commit to ambroff/freebsd-ports that referenced this issue Sep 3, 2023
This is required so py-pytest-cov is functional with newer versions of
py-pytest-xdist [1].

While here, appease portlint by shifting where variables (`CONFLICTS`,
etc) are defined.

1. pytest-dev/pytest-cov#422

PR:	269360
Reviewed by:	yuri
Approved by:	dbaio (maintainer timeout; 5 months)
Co-Authored By:	Yuri Victorovich <yuri@freebsd.org>
Differential Revision: https://reviews.freebsd.org/D39035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants