fix/rsyncdir deprecation #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ssbarnea
commented
Oct 26, 2022
ssbarnea
commented
- Update changelog. Close New release needed to work with latest pytest-xdist pytest-dev/pytest-cov#422.
- Bump version: 2.10.0 → 2.10.1
- Update config.rst wrt ignored .coveragerc settings
- Rewrite the whole paragraph and use a block to make it stand out more.
- Inherit coverage context in subprocesses
- Do not install empty console_scripts entry point
- Change example configs to support tox -e pyXX
- Update setup.py
- Update skel; migrate to travis-ci.com.
- Update test deps.
- Oops.
- Turns out there were some internal changes in the pytester plugin.
- Skip this on 3.8+
- Skip this on 3.8+
- Update changelog.
- Fix link name.
- Bump version: 2.10.1 → 2.11.0
- Fix custom commands with newer setuptools
- Update changelog.
- Bump version: 2.11.0 → 2.11.1
- Update test deps. Remove unnecessary assertion. Closes test suite fails with coverage 5.4 pytest-dev/pytest-cov#452.
- Added toml as extra (Added toml as extra pytest-dev/pytest-cov#410)
- change in setup.py from BSD to MIT to match LICENSE file (change license in setup.py from BSD to MIT to match LICENSE file pytest-dev/pytest-cov#467)
- Fix version value. Fixes pytest_cov.__version__ string is broken on >=2.10.1 pytest-dev/pytest-cov#468.
- fix link in readme (fix link in readme pytest-dev/pytest-cov#470)
- Fix configuration file, ref f2ee249.
- Update changelog.
- Bump version: 2.11.1 → 2.12.0
- Update appveyor envs. Workaround pypy install problem.
- Remove use of rsyncdir
I took a while to figure out why coverage wasn't working correctly for our large project until yesterday, when I read the paragraph that called out the `.coveragerc` options that `pytest-cov` ignores. This PR makes that part of the documentation "pop" a bit more. I considered moving it under "Caveats", but decided that that would mean rewriting "Caveats" to have two separate issues, rather than the one that it currently explains.
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
The empty 'console_scripts' entry point serves no purpose, and it is rather unlikely for it to contain any script in the near future. Its presence confuses Gentoo missing dependency checks.
Fix custom commands to handle additional arguments to the run() method.
This is needed with newer versions of setuptools since they've started
passing 'show_deprecation' kwarg in easy_install command, and this
resulted in the following error:
```
Traceback (most recent call last):
File "/tmp/pytest-cov/./setup.py", line 86, in <module>
setup(
File "/usr/lib/python3.9/site-packages/setuptools/__init__.py", line 153, in setup
return distutils.core.setup(**attrs)
File "/usr/lib/python3.9/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib/python3.9/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/lib/python3.9/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/lib/python3.9/site-packages/setuptools/command/install.py", line 67, in run
self.do_egg_install()
File "/usr/lib/python3.9/site-packages/setuptools/command/install.py", line 117, in do_egg_install
cmd.run(show_deprecation=False)
TypeError: run() got an unexpected keyword argument 'show_deprecation'
```
While at it, future-proof all overriden commands to accept pass any
arguments through.
* added toml extra * Update AUTHORS.rst * Update CHANGELOG.rst * chain toml dependency to coverage's toml dependency Co-authored-by: Thomas Grainger <tagrain@gmail.com> * move coverage's toml dependency from extras to install_requires * udpate changelog phrase Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Fixes: #557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.