-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize test requirements #957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This env pins shouldn't be in extras. They should be in pip-compile lockfiles instead.
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of not being permanently lashed to one particular tool
- Move test requirements from tox.ini to a test extra - Removes unused test requirements - Bumps test requirements to decrease change of running outdated version while developing, including avoidance of pytest-dev/pytest-cov#422
@greg-hellings we are not talking about any tools here. @ssbarnea is trying to shove tests execution virtualenv deps into the metadata of a pip-installable distribution that is completely unrelated to setting up the test environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test deps should be (1) installable w/o the dist itself. They should be pinned (2). And those pins should be auto-updatable by tools like dependabot and similar. I don't see how adding them to dist metadata would help here. I'd say that it's harmful to add them to runtime deps. Besides, influencing setuptools
in the virtualenv is not a good idea either.
I already considered that after you introduced them to docs. Still I have some concerns that too tight control over them would translate into few additional issues:
Note that I am not strongly against dependabot approach. I only stated my concerns and why I prefer using extras with range instead of pinning. Still, I am willing to accommodate other preferences. Lets see what others think, adding feedback-needed label. |
Dropped in favour of #1011 alternative |
version while developing. Avoids New release needed to work with latest pytest-xdist pytest-dev/pytest-cov#422
This enables running of tests w/o tox, with just
pip install -e .[test]
or similar, something that was not possible before.Update: Please check https://discuss.python.org/t/is-it-preferable-to-add-test-dependensies-as-an-extra-require-instead-of-tox-ini/4984 thread if you have doubts if this approach may not be good.