Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

result: keep original traceback and reraise with it #504

Merged
merged 2 commits into from
Apr 30, 2024

Commits on Apr 28, 2024

  1. Remove useless with_traceback calls

    These do nothing, I was just confused.
    bluetech committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    480c975 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. result: keep original traceback and reraise with it

    The `Result` API allows the same exception to be raised multiple times.
    In Python, `Exception.__traceback__` becomes longer everytime an
    exception is raised. This means that on every raise, the exception's
    traceback gets longer and longer.
    
    To prevent this, save the original traceback and always raise using it.
    
    Regressed in pluggy 1.1.0 (fbc4442).
    bluetech committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    93ac1e9 View commit details
    Browse the repository at this point in the history