result: keep original traceback and reraise with it #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These do nothing, I was just confused.
The `Result` API allows the same exception to be raised multiple times. In Python, `Exception.__traceback__` becomes longer everytime an exception is raised. This means that on every raise, the exception's traceback gets longer and longer. To prevent this, save the original traceback and always raise using it. Regressed in pluggy 1.1.0 (fbc4442).
nicoddemus
approved these changes
Apr 29, 2024
RonnyPfannschmidt
approved these changes
Apr 30, 2024
| @@ -136,7 +136,7 @@ def _multicall( | |||
| _raise_wrapfail(teardown, "has second yield") # type: ignore[arg-type] | |||
|
|
|||
| if exception is not None: | |||
| raise exception.with_traceback(exception.__traceback__) | |||
There was a problem hiding this comment.
Do we want to eventually elevate this to a group in a major release
The breakage is entirely due to my misunderstanding of how exceptions work. In pluggy it is less impactful than the similar breakage in pytest because there's no potential of thousands of re-raises of the same exception, but wanted to fix it anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ResultAPI allows the same exception to be raised multiple times. In Python,Exception.__traceback__becomes longer every time an exception is raised. This means that on every raise, the exception's traceback gets longer and longer.To prevent this, save the original traceback and always raise using it.
Regressed in pluggy 1.1.0 (fbc4442).