Update Cirrus Configs #450

abravalheri · 2021-06-02T10:02:01Z

This PR started as an experiment regarding #449, but evolved to some general CirrusCI config updates.

Original issue:

According to https://docs.coveralls.io/supported-ci-services
There is a list of env variables that, when set, are supposed to add support to any arbitrary CI.

I have added these env vars to the cirrus config. They do improve the reports, but not remove the need for the token.
I have a workaround in mind that I will propose by commenting #449

coveralls · 2021-06-03T13:56:10Z

Pull Request Test Coverage Report for Build 5826022579896320

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.281%

Totals
Change from base Build #650:	0.0%
Covered Lines:	1630
Relevant Lines:	1662

💛 - Coveralls

This is an attempt to fix #449 According to https://docs.coveralls.io/supported-ci-services There is a list of env variables that, when set, are supposed to add support to any arbitrary CI.

abravalheri · 2021-07-24T19:31:25Z

.cirrus.yml

-    REQUESTS_CA_BUNDLE: ''
-    CURL_CA_BUNDLE: ''
+    # REQUESTS_CA_BUNDLE: ''
+    # CURL_CA_BUNDLE: ''
    # ^  deactivate SSL checking to avoid error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:661)


For the time being this problem is problem is gone, so let's not bypass security verifications if we absolutely don't need to (I am leaving the code commented in the case we face the issue again in the future).

abravalheri · 2021-07-24T19:35:31Z

.cirrus.yml

+  CI_BRANCH: ${CIRRUS_BRANCH}
+  CI_PULL_REQUEST: ${CIRRUS_PR}
+  CI_BUILD_NUMBER: ${CIRRUS_BUILD_ID}
+  CI_BUILD_URL: https://cirrus-ci.com/build/${CIRRUS_BUILD_ID}


New feature I contributed to coveralls-python improving the quality of the reports.

(I also think this allows coveralls github bot to post a comment in the PR with coverage changes).

abravalheri · 2021-07-24T19:36:07Z

.cirrus.yml

-    git reset --hard %CIRRUS_CHANGE_IN_REPO%
+      git clone --recursive https://x-access-token:%CIRRUS_REPO_CLONE_TOKEN%@github.com/%CIRRUS_REPO_FULL_NAME%.git %CIRRUS_WORKING_DIR% &
+      git fetch origin pull/%CIRRUS_PR%/head:pull/%CIRRUS_PR% &
+      git reset --hard %CIRRUS_CHANGE_IN_REPO%


Added indentation to make it easer to spot the conditional

abravalheri · 2021-07-24T19:36:34Z

.cirrus.yml

@@ -117,24 +124,24 @@ windows_task:
  tools_cache:
    folder: 'C:\tools'
    fingerprint_script:
-      - ps: echo "$env:CIRRUS_OS - nuget v5.6.0 - git v2.27.0"
+      - ps: echo "$env:CIRRUS_OS - nuget v5.10.0 - git 2.32.0.2"


Updated version of windows tools

abravalheri · 2021-07-24T19:36:46Z

.cirrus.yml

    - name: test (OS X)
-      osx_instance: {image: "catalina-xcode"}
+      macos_instance: {image: "big-sur-xcode"}


Updated version of OSX image

abravalheri · 2021-07-24T19:36:54Z

.cirrus.yml

    - name: test (Linux - Anaconda)
-      container: {image: "continuumio/anaconda3:2019.03"}
+      container: {image: "continuumio/anaconda3:2021.05"}


Updated conda version

abravalheri · 2021-07-24T19:37:34Z

.cirrus.yml

-  name: typecheck (Linux - 3.8)
-  container: {image: "python:3.8-buster"}  # most recent => better type support
+  name: typecheck (Linux - 3.9)
+  container: {image: "python:3.9-buster"}  # most recent => better type support


The most recent the version, the better type checking support 🤷‍♂️

abravalheri · 2021-07-24T19:38:35Z

.cirrus.yml

+    - name: test (Linux - 3.10)
+      allow_failures: true  # Python version is not stable
+      container: {image: "python:3.10-rc-buster"}
+      install_script: *debian-install


3.10 is around the corner, so let's check it also.

abravalheri · 2021-07-24T19:40:37Z

tests/extensions/test_venv.py

+                )
+            else:
+                raise
+


As always, creating venvs inside virtualenvs inside conda envs is tricky... And when conda updates things break...
I think failures in this test case are acceptable. If the users has PyScaffold installed with conda, chances are they prefer to use conda envs instead of virtualenvs anyway.

pyscaffold/pyscaffold#450

abravalheri · 2021-07-25T12:12:32Z

Changes in the generated project are verified in pyscaffold/ci-tester#2

FlorianWilhelm · 2021-07-25T20:07:30Z

Looks really good and thanks for all the comments in this PR.

abravalheri · 2021-07-25T20:59:04Z

Thank you very much @FlorianWilhelm

pyscaffold/pyscaffold#450

abravalheri force-pushed the issue-449 branch from 54f476a to cbd286f Compare June 2, 2021 10:27

abravalheri mentioned this pull request Jun 2, 2021

Environment variables as defined in Coveralls official docs seem to not be checked TheKevJames/coveralls-python#299

Closed

abravalheri force-pushed the issue-449 branch from a51271d to 0eb4e90 Compare June 2, 2021 18:59

This comment has been minimized.

Sign in to view

abravalheri added the waiting external dependency Blocked since it requires changes/information from external dependencies label Jun 4, 2021

abravalheri force-pushed the issue-449 branch 2 times, most recently from 91110f8 to 07ca37e Compare July 22, 2021 20:28

abravalheri added 5 commits July 22, 2021 22:10

Attempt: env vars listed in coveralls docs

6c4b684

This is an attempt to fix #449 According to https://docs.coveralls.io/supported-ci-services There is a list of env variables that, when set, are supposed to add support to any arbitrary CI.

Add debug instructions to coveralls

7c65f12

Attempt to impersonate Travis

1f539a5

Remove TRAVIS impersonation and return REPO TOKEN

715c43c

Update/cleanup .cirrus.yml

1420bd2

abravalheri force-pushed the issue-449 branch 3 times, most recently from 8c7839f to 8d4da86 Compare July 23, 2021 01:18

Handle conda errors for nested venv

5bd47d4

abravalheri force-pushed the issue-449 branch from 8d4da86 to 5bd47d4 Compare July 23, 2021 19:11

Configure tox to pass "USING_CONDA" env

ab3f777

abravalheri force-pushed the issue-449 branch from 284e20c to ab3f777 Compare July 24, 2021 13:27

abravalheri added 2 commits July 24, 2021 17:08

Update Windows tools on .cirrus.yml

7e0743f

Update cirrus template

1585605

abravalheri commented Jul 24, 2021

View reviewed changes

abravalheri changed the title ~~[WIP] Attempt to fix #449~~ Update Cirrus Configs Jul 24, 2021

abravalheri marked this pull request as ready for review July 24, 2021 19:50

abravalheri added a commit to pyscaffold/ci-tester that referenced this pull request Jul 25, 2021

Companion PR for PyScaffold#450

ecd2b1a

pyscaffold/pyscaffold#450

abravalheri mentioned this pull request Jul 25, 2021

Companion PR for PyScaffold#450 pyscaffold/ci-tester#2

Merged

abravalheri removed the waiting external dependency Blocked since it requires changes/information from external dependencies label Jul 25, 2021

abravalheri merged commit c77dbf7 into master Jul 25, 2021

abravalheri deleted the issue-449 branch July 25, 2021 20:58

abravalheri added a commit to pyscaffold/ci-tester that referenced this pull request Jul 25, 2021

Companion PR for PyScaffold#450

0e43608

pyscaffold/pyscaffold#450

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Cirrus Configs #450

Update Cirrus Configs #450

abravalheri commented Jun 2, 2021 •

edited

This comment has been minimized.

coveralls commented Jun 3, 2021 •

edited

abravalheri Jul 24, 2021

abravalheri Jul 24, 2021

abravalheri Jul 24, 2021

abravalheri Jul 24, 2021

abravalheri Jul 24, 2021

abravalheri Jul 24, 2021

abravalheri Jul 24, 2021

abravalheri Jul 24, 2021

abravalheri Jul 24, 2021

abravalheri commented Jul 25, 2021

FlorianWilhelm commented Jul 25, 2021

abravalheri commented Jul 25, 2021

Update Cirrus Configs #450

Update Cirrus Configs #450

Conversation

abravalheri commented Jun 2, 2021 • edited

This comment has been minimized.

coveralls commented Jun 3, 2021 • edited

Pull Request Test Coverage Report for Build 5826022579896320

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abravalheri commented Jul 25, 2021

FlorianWilhelm commented Jul 25, 2021

abravalheri commented Jul 25, 2021

abravalheri commented Jun 2, 2021 •

edited

coveralls commented Jun 3, 2021 •

edited