New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment variables as defined in Coveralls official docs seem to not be checked #299
Comments
abravalheri
added a commit
to abravalheri/coveralls-python
that referenced
this issue
Jun 3, 2021
The official docs for Coveralls define a set of generic environment variables that once defined should support any CI environment: https://docs.coveralls.io/supported-ci-services (bottom of the page). The changes implemented in this PR attempt to read those variables but allows the values to be overwritten by any CI-specific configuration currently supported. They were also inspired by the official client (coveralls-ruby - lib/coveralls/configuration.rb - set_standard_service_params_for_generic_ci).
abravalheri
changed the title
Environment variables as defined in Coveralls official dogs seem to not be checked
Environment variables as defined in Coveralls official docs seem to not be checked
Jun 3, 2021
abravalheri
added a commit
to abravalheri/coveralls-python
that referenced
this issue
Jun 14, 2021
The official docs for Coveralls define a set of generic environment variables that once defined should support any CI environment: https://docs.coveralls.io/supported-ci-services (bottom of the page). The changes implemented in this PR attempt to read those variables but allows the values to be overwritten by any CI-specific configuration currently supported. They were also inspired by the official client (coveralls-ruby - lib/coveralls/configuration.rb - set_standard_service_params_for_generic_ci).
abravalheri
added a commit
to abravalheri/coveralls-python
that referenced
this issue
Jul 20, 2021
The official docs for Coveralls define a set of generic environment variables that once defined should support any CI environment: https://docs.coveralls.io/supported-ci-services (bottom of the page). The changes implemented in this PR attempt to read those variables but allows the values to be overwritten by any CI-specific configuration currently supported. They were also inspired by the official client (coveralls-ruby - lib/coveralls/configuration.rb - set_standard_service_params_for_generic_ci).
TheKevJames
pushed a commit
that referenced
this issue
Jul 20, 2021
…300) The official docs for Coveralls define a set of generic environment variables that once defined should support any CI environment: https://docs.coveralls.io/supported-ci-services (bottom of the page). The changes implemented in this PR attempt to read those variables but allows the values to be overwritten by any CI-specific configuration currently supported. They were also inspired by the official client (coveralls-ruby - lib/coveralls/configuration.rb - set_standard_service_params_for_generic_ci).
Thanks for the PR! |
andy-maier
pushed a commit
to andy-maier/coveralls-python
that referenced
this issue
Dec 23, 2022
…ames#299) (TheKevJames#300) The official docs for Coveralls define a set of generic environment variables that once defined should support any CI environment: https://docs.coveralls.io/supported-ci-services (bottom of the page). The changes implemented in this PR attempt to read those variables but allows the values to be overwritten by any CI-specific configuration currently supported. They were also inspired by the official client (coveralls-ruby - lib/coveralls/configuration.rb - set_standard_service_params_for_generic_ci).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, first of all, thank you very much for the package, it really helps a lot.
After the changes in the policy of TravisCI for opensource projects, I have been trying to move all the open source projects I participate to CirrusCI, since it have good, "unlimited", support for opensource.
In general using coveralls works perfectly, not many changes required. There is one thing, though, that seems very difficult to understand, and it is caused by the following factors:
COVERALLS_REPO_TOKEN
, otherwise the errorNot on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.
happens.coveralls
fails to run... The sad part is that having statics about how much PRs impact on the coverage is very handy...When searching for a solution, I could find on coveralls docs, that any CI (not only travis) could be supported if the following environment variables are available:
However it does not seem to solve the problem, as you can see in the following example (pyscaffold/pyscaffold#450):
Relevant output of
coveralls debug
:So I was wondering:
COVERALLS_REPO_TOKEN
that still allows submitting PR coverages by regular contributors?coveralls
CLI actually reading the environment variables as documented at the bottom of the official docs page?The text was updated successfully, but these errors were encountered: