Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/20221203/fixed dist info requirement for deploy #1156

Conversation

Scoppio
Copy link
Contributor

@Scoppio Scoppio commented Oct 3, 2022

Removes dependency of dist-info folder inside the __init__.py file, fixing break when running the package in "slim" environment due to the lack of the METADATA file.

…to be present in the project to load __version__ variable with current version of the code
@snowman2 snowman2 added this to the 3.4.1 milestone Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1156 (2ef4235) into main (bc7805c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1156   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files          18       18           
  Lines        1703     1703           
=======================================
  Hits         1638     1638           
  Misses         65       65           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@snowman2
Copy link
Member

snowman2 commented Oct 3, 2022

@Scoppio, thanks 👍

@snowman2 snowman2 merged commit 5723f37 into pyproj4:main Oct 3, 2022
@Scoppio Scoppio deleted the fix/20221203/fixed-dist-info-requirement-for-deploy branch October 4, 2022 01:30
@snowman2 snowman2 mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dist-info breaks project on version 3.4.0
2 participants