hooks: pyproj: collect metadata for pyproj >= 3.4.0 #505
Conversation
rokm
force-pushed
the
hook-pyproj-3.4.0
branch
from
d7bbae4
to
5373490
Compare
|
They did revert it (pyproj4/pyproj#1156). That's why I was putting off doing anything about it. I was hoping they'd release 3.4.1 then we could pretend 3.4.0 never happened. |
|
Ah, fair enough. Let's ignore 3.4, then. |
rokm
force-pushed
the
hook-pyproj-3.4.0
branch
from
5373490
to
83f98bc
Compare
|
If pyproj 3.4.1 is happening on December 1st, this means we have a whole-month-long window during which we'll be dealing with bug reports about this. Therefore, I'm reopening this PR, but I've changed the version check from We will need to push out new hooks-contrib release, though... |
rokm
force-pushed
the
hook-pyproj-3.4.0
branch
from
83f98bc
to
d19ede5
Compare
In version 3.4.0, pyproj's `__init__.py` queries its own version via `importlib.metadata.version(__package__)`, which requires the package metadata to be collected. This change seems to have been already reverted, so it will not affect subsequent pyproj releases.
rokm
force-pushed
the
hook-pyproj-3.4.0
branch
from
d19ede5
to
629bcbf
Compare
|
Go ahead and hit the release button after merging. |
|
I'll try to find out what the deal with double headings in ChangeLog is, and then make a release. |
|
It'll be the towncrier template again. This is at least the 4th time they've changed their minds on whether the headings should be specified in the template or inserted automatically. |
As of version 3.4.0, pyproj's
__init__.pyqueries its own version viaimportlib.metadata.version(__package__), which requires the package metadata to be collected.