Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding codecov configuration #2693

Merged
merged 15 commits into from Jul 11, 2021
Merged

Adding codecov configuration #2693

merged 15 commits into from Jul 11, 2021

Conversation

tanvimoharir
Copy link
Contributor

@tanvimoharir tanvimoharir commented Jun 1, 2021

Summary of changes

Added minimal configuration for codecov.

Closes #2642

Pull Request Checklist

  • Changes have tests (N/A)

  • News fragment added in [changelog.d/]. (N/A?)
    (See [documentation][PR docs] for details)

  • I have hereby reviewed ,and agree to follow, the PSF Code of Conduct

Added minimal configuration
@tanvimoharir tanvimoharir mentioned this pull request Jun 1, 2021
1 task
@tanvimoharir tanvimoharir marked this pull request as ready for review June 9, 2021 15:45
@webknjaz
Copy link
Member

We'll need to wait for @jaraco to allow the CI run, I don't have access to that button. But looks good otherwise.

@webknjaz webknjaz requested a review from jaraco June 23, 2021 11:47
tanvimoharir and others added 2 commits June 23, 2021 17:52
Updating from GH UI

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
.github/workflows/main.yml Outdated Show resolved Hide resolved
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks acceptable. I don't yet see any results in the runners. I'll probably remove all of the options that aren't necessary and trust that the defaults are good enough.

Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like codecov isn't finding any coverage reports. See if you can find a way to retain those artifacts for upload, preferably without altering any existing lines.

@webknjaz
Copy link
Member

webknjaz commented Jul 5, 2021

GHA logs have this:

==> Python coveragepy not found

🤔 Does it expect that pip install coverage is executed beforehand? It shouldn't need this.

@webknjaz
Copy link
Member

webknjaz commented Jul 5, 2021

I'll probably remove all of the options that aren't necessary

Flags are necessary because these are useful in the report view showing what envs hit certain lines. So plz recover that option. And disabling gcov sounds right too. You can also specify files: to point exactly to the file produced by pytest-cov.

@webknjaz
Copy link
Member

webknjaz commented Jul 5, 2021

Does it expect that pip install coverage is executed beforehand? It shouldn't need this.

Looks like it's exactly what it expects: the README example shows installing+running pytest-cov in a bare env (w/o a venv created by tox).

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@webknjaz webknjaz requested a review from jaraco July 5, 2021 15:33
@webknjaz
Copy link
Member

webknjaz commented Jul 7, 2021

@tanvimoharir could you recover the action options under with: per my earlier comments?

@jaraco you'll need to re-approve the CI run for us to see if the patch works.

@tanvimoharir
Copy link
Contributor Author

@tanvimoharir could you recover the action options under with: per my earlier comments?

@jaraco you'll need to re-approve the CI run for us to see if the patch works.

Thanks, I have added back the actions options per your earlier comment.

.github/workflows/main.yml Outdated Show resolved Hide resolved
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@jaraco jaraco merged commit 3f20c10 into pypa:main Jul 11, 2021
@jaraco
Copy link
Member

jaraco commented Jul 11, 2021

Thanks for the diligent work on putting this together.

@tanvimoharir
Copy link
Contributor Author

Thanks @webknjaz and @jaraco
I'm still new to this and this was a good learning for me. I will continue to learn more and find some other (beginner friendly) issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resurrect reporting to codecov
4 participants