Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect reporting to codecov #2642

Closed
1 task done
webknjaz opened this issue Apr 16, 2021 · 4 comments · Fixed by #2693
Closed
1 task done

Resurrect reporting to codecov #2642

webknjaz opened this issue Apr 16, 2021 · 4 comments · Fixed by #2693

Comments

@webknjaz
Copy link
Member

setuptools version

main

Python version

N/A

OS

N/A

Additional environment information

No response

Description

I've been doing some security audit after the recent codecov supply chain attack and discovered that there's been no coverage updates on the service since Dec 20.

I tracked it down to this change: #2486.

Funny enough, I've left a number of comments reviewing that but still missed this issue ;)

It used to be integrated in Travis CI and AppVeyor

and the toxenv is still in place but its invocation never survives the migration to GHA and so this needs to be corrected.

Fixing this should be pretty straightforward — just integrate https://github.com/codecov/codecov-action.

Expected behavior

Coverage to be actually reported to codecov.

How to Reproduce

Look at https://app.codecov.io/gh/pypa/setuptools/commits — the last known report was 4 month ago.

Output

N/A

Code of Conduct

  • I agree to follow the PSF Code of Conduct
@webknjaz webknjaz added Needs Triage Issues that need to be evaluated for severity and status. bug good first issue help wanted Needs Implementation Issues that are ready to be implemented. task trivial and removed Needs Triage Issues that need to be evaluated for severity and status. labels Apr 16, 2021
@tanvimoharir
Copy link
Contributor

Hi,
I would like to work on this.
Thanks

@webknjaz
Copy link
Member Author

Sure, feel free to send a PR.

@tanvimoharir
Copy link
Contributor

hi @webknjaz ,
I have drafted a PR (#2693). I have not worked with codecov before (not very confident about it either) which is why I marked the PR as draft.
Let me know if the change looks correct or otherwise.
Thanks

@tanvimoharir
Copy link
Contributor

I may have missed few things, checking the build failure and looking into it.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants