Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy from 0.982 to 0.990 #7769

Merged
merged 6 commits into from Nov 14, 2022
Merged

Bump mypy from 0.982 to 0.990 #7769

merged 6 commits into from Nov 14, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 14, 2022

Bumps mypy from 0.982 to 0.990.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mypy](https://github.com/python/mypy) from 0.982 to 0.990.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.982...v0.990)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependency Label for github dependabot label Nov 14, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Needs take over 🛎️ Orignal implementer went away but the code could be salvaged. label Nov 14, 2022
@coveralls
Copy link

coveralls commented Nov 14, 2022

Pull Request Test Coverage Report for Build 3463390811

  • 9 of 10 (90.0%) changed or added relevant lines in 9 files are covered.
  • 34 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.0008%) to 95.403%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/testutils/_primer/primer_run_command.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pylint/checkers/typecheck.py 34 96.05%
Totals Coverage Status
Change from base Build 3460107264: 0.0008%
Covered Lines: 17351
Relevant Lines: 18187

💛 - Coveralls

@github-actions

This comment has been minimized.

@cdce8p cdce8p added Skip news 🔇 This change does not require a changelog entry and removed Needs take over 🛎️ Orignal implementer went away but the code could be salvaged. labels Nov 14, 2022
@cdce8p cdce8p self-assigned this Nov 14, 2022
@github-actions

This comment has been minimized.

@@ -132,8 +132,7 @@ class ExtraMessageOptions(TypedDict, total=False):
Tuple[str, str, str],
Tuple[str, str, str, ExtraMessageOptions],
]
# Mypy doesn't support recursive types (yet), see https://github.com/python/mypy/issues/731
DirectoryNamespaceDict = Dict[Path, Tuple[argparse.Namespace, "DirectoryNamespaceDict"]] # type: ignore[misc]
DirectoryNamespaceDict = Dict[Path, Tuple[argparse.Namespace, "DirectoryNamespaceDict"]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@DanielNoord DanielNoord enabled auto-merge (squash) November 14, 2022 16:46
@cdce8p cdce8p disabled auto-merge November 14, 2022 16:50
@cdce8p cdce8p merged commit 5b57f94 into main Nov 14, 2022
@cdce8p cdce8p deleted the dependabot/pip/mypy-0.990 branch November 14, 2022 16:56
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit a1cedde

@cdce8p
Copy link
Member

cdce8p commented Nov 14, 2022

Does anyone have an idea why the docs linkcheck constantly fails?
https://github.com/PyCQA/pylint/actions/runs/3463507407/jobs/5784541243#step:8:1276

@Pierre-Sassoulas
Copy link
Member

Maybe a link is genuinely permanentely broken.

@Pierre-Sassoulas
Copy link
Member

Seems like this one was cancelled though. Too much pipeline at the same time ?

@DanielNoord
Copy link
Collaborator

Seems like the timeout is just too short. Needs more than 10 minutes with the increased number of pages due to messages getting updated examples.

@cdce8p
Copy link
Member

cdce8p commented Nov 14, 2022

Seems like the timeout is just too short. Needs more than 10 minutes with the increased number of pages due to messages getting updated examples.

Didn't realize it had a timeout. Opened #7771 to bump it to 20min.

@DanielNoord
Copy link
Collaborator

Thanks @cdce8p. Wasn't able to do so myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Label for github dependabot Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants