Make TryStar not crash #13991
Merged
Make TryStar not crash #13991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @svalentin @JukkaL This is probably mostly correct, but I haven't thought about it super hard. Definitely should stop crashes! |
This comment has been minimized.
This comment has been minimized.
|
I think as long as it's not crashing it should be fine. But will let @JukkaL take a closer look. That said, a test is failing. I think we have some an incorrect py311 check. |
|
Found something that needed to be changed, but weird that it worked locally for me (oh figured it out, I had an RC build of 3.11 which missed python/cpython#96588) |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Going to go ahead and merge + backport since it fixes the crash and doesn't behave entirely terribly. Ivan said he would look into actual support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.