Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive for undefined-loop-variable for lambda in first of two loops #6479

Merged
merged 4 commits into from May 1, 2022

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
🐛 Bug fix

Description

Closes #6419

@jacobtylerwalls jacobtylerwalls added Bug 🪲 Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer False Positive 🦟 A message is emitted but nothing is wrong with the code labels May 1, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.13.8 milestone May 1, 2022
@coveralls
Copy link

coveralls commented May 1, 2022

Pull Request Test Coverage Report for Build 2253967812

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 95.147%

Files with Coverage Reduction New Missed Lines %
pylint/checkers/variables.py 16 96.65%
Totals Coverage Status
Change from base Build 2250268254: 0.001%
Covered Lines: 15783
Relevant Lines: 16588

💛 - Coveralls

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@Pierre-Sassoulas Pierre-Sassoulas merged commit 9d30042 into pylint-dev:main May 1, 2022
@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented May 1, 2022

Hmm I'm going to fix that by amending the commit on main. (Or we'd need to cherry-pick two commits for 2.13.8)

@DanielNoord
Copy link
Collaborator

Can't remember if I ever asked this: but why don't we just disable fixme? It seems like such a silly linting warning..

Pierre-Sassoulas added a commit that referenced this pull request May 1, 2022
@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented May 1, 2022

Can't remember if I ever asked this: but why don't we just disable fixme? It seems like such a silly linting warning..

We didn't, because #3512 is overwhelming, but it's supposed to happens 😄 I think I'll have to check what need to be done for this one because it's not hard to do, we only have to follow Ashley's tabular lead (but it's going to be easier if I list what is optional what is not and what needs to change for 3512 to be considered done)..

@jacobtylerwalls jacobtylerwalls deleted the lambda-two-loops branch May 1, 2022 16:00
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels May 2, 2022
Pierre-Sassoulas added a commit that referenced this pull request May 2, 2022
…of two loops (#6479)


Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pierre-Sassoulas added a commit that referenced this pull request May 2, 2022
…of two loops (#6479)


Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported Bug 🪲 False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W0631 undefined-loop-variable false positive for lambda statements inside first of two loops
4 participants