Skip to content

Commit

Permalink
Revert "Fix false positive for undefined-loop-variable for lambda i…
Browse files Browse the repository at this point in the history
…n first of two loops (#6479)"

This reverts commit 9d30042.
  • Loading branch information
Pierre-Sassoulas committed May 1, 2022
1 parent 9d30042 commit a09c328
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 34 deletions.
5 changes: 0 additions & 5 deletions ChangeLog
Expand Up @@ -242,11 +242,6 @@ What's New in Pylint 2.13.8?
============================
Release date: TBA

* Fix a false positive for ``undefined-loop-variable`` for a variable used in a lambda
inside the first of multiple loops.

Closes #6419

* Fix a crash when linting a file that passes an integer ``mode=`` to
``open``

Expand Down
5 changes: 0 additions & 5 deletions doc/whatsnew/2.13.rst
Expand Up @@ -625,11 +625,6 @@ Other Changes

Closes #5930

* Fix a false positive for ``undefined-loop-variable`` for a variable used in a lambda
inside the first of multiple loops.

Closes #6419

* Fix a crash when linting a file that passes an integer ``mode=`` to
``open``

Expand Down
5 changes: 1 addition & 4 deletions pylint/checkers/variables.py
Expand Up @@ -2198,10 +2198,7 @@ def _loopvar_name(self, node: astroid.Name) -> None:
# the usage is safe because the function will not be defined either if
# the variable is not defined.
scope = node.scope()
# FunctionDef subclasses Lambda due to a curious ontology. Check both.
# See https://github.com/PyCQA/astroid/issues/291
# TODO: Revisit when astroid 3.0 includes the change
if isinstance(scope, nodes.Lambda) and any(
if isinstance(scope, nodes.FunctionDef) and any(
asmt.scope().parent_of(scope) for asmt in astmts
):
return
Expand Down
20 changes: 0 additions & 20 deletions tests/functional/u/undefined/undefined_loop_variable.py
Expand Up @@ -119,23 +119,3 @@ def for_else_raises(iterable):
]
for item in lst
]


def lambda_in_first_of_two_loops():
"""https://github.com/PyCQA/pylint/issues/6419"""
my_list = []
for thing in my_list:
print_it = lambda: print(thing) # pylint: disable=cell-var-from-loop
print_it()

for thing in my_list:
print(thing)


def variable_name_assigned_in_body_of_second_loop():
for alias in tuple(bigger):
continue
for _ in range(3):
alias = True
if alias:
print(alias)

0 comments on commit a09c328

Please sign in to comment.