Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing to all calls to self.stats #4973

Merged
merged 10 commits into from Sep 15, 2021
Merged

Add typing to all calls to self.stats #4973

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4cbbcdf
Add typing to all calls to ``self.stats``
DanielNoord Sep 6, 2021
f782e2a
Add ``CheckerStatistic`` class to ``pylint/typing``
DanielNoord Sep 6, 2021
0528ee5
Guard `typing.Counter` import
DanielNoord Sep 6, 2021
04706af
Add ``disable`` for import of ``conftest``
DanielNoord Sep 6, 2021
0c45661
Implement code review
DanielNoord Sep 6, 2021
d35f86a
Apply suggestions from code review
DanielNoord Sep 14, 2021
c365d8b
Merge branch 'main' into typing-stats
DanielNoord Sep 14, 2021
ebddfa9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 14, 2021
6d76ab7
Add `Any` to kwargs
DanielNoord Sep 14, 2021
1841e65
Add Iterable and return annotation
DanielNoord Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/pyreverse/test_writer.py
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@
from unittest.mock import Mock

import pytest
from conftest import PyreverseConfig # type: ignore
from conftest import PyreverseConfig # type: ignore #pylint: disable=no-name-in-module
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the import of conftest introduced in 2500086 failed the pre-commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be from pylint.pyrevers.conftest import PyreverseConfig?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion here: #4950 (comment)
Seems like we can't fix this without a (big) refactor


from pylint.pyreverse.diadefslib import DefaultDiadefGenerator, DiadefsHandler
from pylint.pyreverse.inspector import Linker, Project
Expand Down