Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing to all calls to self.stats #4973

Merged
merged 10 commits into from Sep 15, 2021
Merged

Add typing to all calls to self.stats #4973

merged 10 commits into from Sep 15, 2021

Commits on Sep 6, 2021

  1. Add typing to all calls to self.stats 

    All checkers inherit from a baseclass which has a ``stats`` attribute.
This attribute has a fairly unmanageable type, but the current typing includes all variations of the attribute.
Other changes not directly related to ``self.stats`` are due to ``mypy``warnings.
This incorporate the feedback received in pylint-dev#4954
    @DanielNoord
    DanielNoord committed Sep 6, 2021
    Copy the full SHA
    4cbbcdf View commit details
    Browse the repository at this point in the history

  2. Add CheckerStatistic class to pylint/typing

    @DanielNoord
    DanielNoord committed Sep 6, 2021
    Copy the full SHA
    f782e2a View commit details
    Browse the repository at this point in the history

  3. Guard typing.Counter import

    @DanielNoord
    DanielNoord committed Sep 6, 2021
    Copy the full SHA
    0528ee5 View commit details
    Browse the repository at this point in the history

  4. Add disable for import of conftest

    @DanielNoord
    DanielNoord committed Sep 6, 2021
    Copy the full SHA
    04706af View commit details
    Browse the repository at this point in the history

  5. Implement code review

    @DanielNoord
    DanielNoord committed Sep 6, 2021
    Copy the full SHA
    0c45661 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
    @DanielNoord @cdce8p
    DanielNoord and cdce8p committed Sep 14, 2021
    Copy the full SHA
    d35f86a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into typing-stats

    @DanielNoord
    DanielNoord committed Sep 14, 2021
    Copy the full SHA
    c365d8b View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 14, 2021
    Copy the full SHA
    ebddfa9 View commit details
    Browse the repository at this point in the history

  4. Add Any to kwargs

    @DanielNoord
    DanielNoord committed Sep 14, 2021
    Copy the full SHA
    6d76ab7 View commit details
    Browse the repository at this point in the history

  5. Add Iterable and return annotation

    @DanielNoord
    DanielNoord committed Sep 14, 2021
    Copy the full SHA
    1841e65 View commit details
    Browse the repository at this point in the history