Hot-fix master following release of python 3.10-rc's new version #4801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Bug 🪲
Maintenance
Pierre-Sassoulas
force-pushed
the
fix-master-so-we-can-merge-again
branch
from
3ebf245
to
4039852
Compare
|
I wanted to fix this, but not quite sure what the original test is trying to test for. |
|
Yes the part that look like a type assignment in 3.10 was invalid before 3.10 and crashed in astroid <=2.6.4, see #4439 |
|
So no need to change the tests to be able to also run on 3.10? |
|
Yes I think the change is ok as it is, if there was multiple use case in the functional test we'd have to separate them but there is just this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This is a hot fix, the real fix escape me right now.