Improve wording on W0402 message

[omarandlorraine]

Type of Changes

	Type
✓	📜 Docs

Description

I left the scrolly thing up there since the Issue has the Documentation tag, hope that's the right thing to do.

So I have improved the wording on W0402; it now says "Deprecated module <module name>" for consistency and style.

Closes #6169

[omarandlorraine]

Oh pants!

I think commit f4d4107 should not be part of this branch. Should I try and rewrite history or maybe it doesn't matter?

(the commit in question belongs with PR #6280)

(Okay, I just went ahead and reverted the duff commit. Maybe a rebase could get rid of the commit and the revert?)

[omarandlorraine]

Does anyone know what rstcheck and mypy means and why it's failing the precommit hook?

[omarandlorraine]

Oh, magically rstcheck passes since I reverted f4d4107. Maybe rstcheck is a changelog sanity checker, who knows.

But mypy still seems to bomb out with some more serious-looking errors.

[Pierre-Sassoulas]

Do not take the current pre-commit fail into account, our main branch is broken we'll fix it :)

[DudeNr33]

Does anyone know what rstcheck and mypy means and why it's failing the precommit hook?

rstcheck is a syntax checker for reStructuredText files. It checks all *.rst files as well as Changelog (which is written in reStructuredText as well).
mypy is an optional static type checker for Python and used to check type conflicts in the code base.

I encourage you to install and activate pre-commit in your own development environment according to our docs.
This will run all configured checks against the staged changes when you run git commit.
This not only allows you to fix issues before you push your branch, but also makes it a bit more transparent what the problems are, as you see the tool output directly on your command line.
Last but not least you will quickly learn what the style checks etc. for pylint expect, and you can write code and documentation directly in a way that the pre-commit hooks won't complain. :)

[omarandlorraine]

I encourage you to install and activate pre-commit in your own development environment according to our docs.

Oh, that's a great idea and works really well, thanks

[omarandlorraine]

From what I see, this review needs to be concluded or something before the remaining checks will run.

Sorry if I'm generating a lot of spam, I don't know github that well yet.

[Pierre-Sassoulas]

From what I see, this review needs to be concluded or something before the remaining checks will run.

To prevent bitcoin mining first time contributors need to be approved before the pipeline runs :) You won't have to be approved after this one get merged !

[omarandlorraine]

Can anyone see if the remaining tests are failing because of an issue with the PR or because of that problem with the main branch?

The precommit passes locally on my machine but there is a "Some checks were not successful" on github and I don't understand. It is worth noting that here I have python 3.9.2 only, and this is presumably why the tests for other versions are not being run.

My working tree is clean and up to date with origin/W0402polish, (origin being my github repo.) and git grep -i "uses of a deprecated" returns nothing.

[DanielNoord]

Can anyone see if the remaining tests are failing because of an issue with the PR or because of that problem with the main branch?

The precommit passes locally on my machine but there is a "Some checks were not successful" on github and I don't understand. It is worth noting that here I have python 3.9.2 only, and this is presumably why the tests for other versions are not being run.

My working tree is clean and up to date with origin/W0402polish, (origin being my github repo.) and git grep -i "uses of a deprecated" returns nothing.

Looking at the test output the expected output for deprecated_module_redundant needs to be updated. You can probably do this manually by changing the message in deprecated_module_redundant.txt which can be found in the tests/functional/d dir.

Current failures in pre-commit are indeed from broken main.

[omarandlorraine]

Oh, thanks for taking a look.

That file didn't exist here; that's why I couldn't see it! It's new since PR#6360, which was merged in recently. So I've done the necessaries, let's see if the tests pass this time.

[omarandlorraine]

Okay, now some tests for W1203 are failing. I'm certain I didn't touch W1203.

Am I missing a step here or something?

[DanielNoord]

@omarandlorraine I think you were just a little too quick to merge main. There is actually one more commit on main that is need to fix it. That should fix it!

[omarandlorraine]

Okay, let's try this.

There has been so much toing and froing and pulling and rebasing for this simple pull request. Because someone else is working on the main branch. Is this normal?

[DanielNoord]

Okay, let's try this.

There has been so much toing and froing and pulling and rebasing for this simple pull request. Because someone else is working on the main branch. Is this normal?

No, this not normal. You just caught in 24h of extreme unluckiness.
First we broke one our linter on main because two connected PRs passed all checks on their own, but didn't pass when we committed them to main together.
Then, while we were in the process of fixing that linting message we broke our test suite with another set of connected PRs that passed on their own.

Both issues have now been resolved and there shouldn't be any need to merge main into this branch to get the CI to pass from now on. Just extreme unlucky... Sorry about that! 😄

[Pierre-Sassoulas]

Yeah.. it's the first time main was broken since... maybe august 2021, 8 months ago (#4801), sorry for the unusually bad experience.

[omarandlorraine]

Oh, that's good. I'll keep on contributing in the future then 🙂 I can see that the checks are still failing though. But I can't see the logs, maybe because I'm on my phone right now.

I'll have another look tomorrow.

[DanielNoord]

@omarandlorraine Just a heads up, for some reason you still seem to be missing the necessary commit. efa2a70

You might want to rebase on main. Something like git pull --rebase upstream main should work if you have our repo as your upstream.

[Pierre-Sassoulas]

Took the liberty to rebase because the intense activity on main made the merge strategy problematic.

[coveralls]

Pull Request Test Coverage Report for Build 2192208128

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 95.158%

---

Totals
Change from base Build 2192205394:	0.0%
Covered Lines:	15781
Relevant Lines:	16584

---

💛 - Coveralls

[DanielNoord]

@Pierre-Sassoulas I'm seeing a lot of different emails in the commit messages. Could you give some guidance on how to add those to the contributor list?

[Pierre-Sassoulas]

One of the adresse was "you@example.com" so I removed it. But it's possible to create alias in https://github.com/PyCQA/pylint/blob/main/script/.contributors_aliases.json otherwise.

Thank you for your contribution @omarandlorraine !

[omarandlorraine]

You're welcome!

Thanks for the help merging and closing it.