Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XDG_CACHE_HOME for PYLINTHOME #4661

Merged
merged 2 commits into from Jul 28, 2021
Merged

Use XDG_CACHE_HOME for PYLINTHOME #4661

merged 2 commits into from Jul 28, 2021

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Jul 3, 2021

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

On Linux, analysis date are stored under ~/.pylint.d at the moment, which is not compliant with XDG Base Directory Specification.

As @blueyed commented, I believe pickle files should be located under $XDG_CACHE_HOME rather than $XDG_DATA_HOME.

Closes #3878.

Type of Changes

Type
✨ New feature
🔨 Refactoring
📜 Docs

Related Issue

@coveralls
Copy link

coveralls commented Jul 3, 2021

Coverage Status

Coverage increased (+0.02%) to 92.178% when pulling 8c61b24 on e-kwsm:XDG_CACHE_HOME into a054796 on PyCQA:main.

@Pierre-Sassoulas Pierre-Sassoulas added Enhancement ✨ Improvement to a component task labels Jul 4, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.10.0 milestone Jul 4, 2021
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for implementing this change ! I think there is no breaking changes and it can go in 2.10.0 (ie: we'll merge only when all 2.9.x crashes have been fixed).

ChangeLog Outdated Show resolved Hide resolved
pylint/config/__init__.py Show resolved Hide resolved
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot ! I'm going to merge as soon as we release the last expected 2.9.x

@Pierre-Sassoulas Pierre-Sassoulas merged commit ae6cbd1 into pylint-dev:main Jul 28, 2021
@Pierre-Sassoulas
Copy link
Member

Thank you again for this, it will be available in 2.10.0 :)

@e-kwsm e-kwsm deleted the XDG_CACHE_HOME branch July 28, 2021 20:51
@MestreLion
Copy link

This seems to also (truly) close #1364

@CAM-Gerlach
Copy link
Contributor

FYI, appdirs is effectively unmaintained; platformdirs is the community's forked replacement. Black has already switched, and given this dep was newly added, it would make sense to use the modern, maintained replacement now given its drop-in compatible and fixes numerous long-outstanding bugs with the original, instead of having to switch later if and when things eventually break.

@Pierre-Sassoulas
Copy link
Member

Thanks @CAM-Gerlach I created #4886 for this.

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow and removed task labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pylint XDG Base Directory Specification compliant
5 participants