Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated information from the PYLINT_HOME help #5204

Merged
merged 4 commits into from Oct 26, 2021
Merged

Remove outdated information from the PYLINT_HOME help #5204

merged 4 commits into from Oct 26, 2021

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✓ 🔨 Refactoring
✓ 📜 Docs

Description

While working on the configuration, I encountered a variable that was separated for apparently no good reason and the text was outdated following #4661

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Oct 24, 2021
@coveralls
Copy link

coveralls commented Oct 24, 2021 •
edited

Pull Request Test Coverage Report for Build 1382645166

  • 17 of 18 (94.44%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 93.337%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/config/init.py 4 5 80.0%
Totals Coverage Status
Change from base Build 1381936214: 0.001%
Covered Lines: 13686
Relevant Lines: 14663
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the move-env-help-to-the-logical-place branch from c39a7f5 to 5d9cfaa Compare October 24, 2021 17:44
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.0 milestone Oct 25, 2021
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the move-env-help-to-the-logical-place branch from 5d9cfaa to 367e6c7 Compare October 25, 2021 19:35
DanielNoord
DanielNoord reviewed Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally comfortable reviewing this, as I don't know exactly what pylint does with PYLINT_HOME but the changes seem logical in that pylint.d gets changed to OLD_DEFAULT_PYLINT_HOME.

I think we should be good to merge this.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 17d6926 into main Oct 26, 2021
@Pierre-Sassoulas Pierre-Sassoulas deleted the move-env-help-to-the-logical-place branch October 26, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord left review comments

Assignees
No one assigned
Labels
Documentation 📗 Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pierre-Sassoulas @coveralls @DanielNoord