Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive when map() receives iterable #4104

Merged
merged 1 commit into from Feb 20, 2021
Merged

Fix false positive when map() receives iterable #4104

merged 1 commit into from Feb 20, 2021

Conversation

tiagohonorato
Copy link
Contributor

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Since map() supports iterables, it should not issue builtin-not-iterating for iterable arguments.

Type of Changes

Type
✓ 🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Related Issue

Closes #4078

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.582% when pulling fb12243 on tiagohonorato:map-as-iterating-context into 4faccd0 on PyCQA:master.

@coveralls
Copy link

coveralls commented Feb 18, 2021 •
edited

Coverage Status

Coverage remained the same at 91.429% when pulling 419d23f on tiagohonorato:map-as-iterating-context into ba6a403 on PyCQA:master.

@tiagohonorato tiagohonorato mentioned this pull request Feb 18, 2021
Merged
3 tasks
@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Feb 19, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.7.0 milestone Feb 19, 2021
@tiagohonorato @Pierre-Sassoulas
Fix false positive when map() receives iterable
419d23f 
Since map() supports iterables, it should not issue
builtin-not-iterating for iterable arguments.

Signed-off-by: Tiago Honorato <tiagohonorato1@gmail.com>
@Pierre-Sassoulas
Copy link
Member

Thank you for this merge request as well as #4105 :) And congrat on becoming a pylint contributor !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 570e655 into pylint-dev:master Feb 20, 2021
@tiagohonorato
Copy link
Contributor Author

@Pierre-Sassoulas pylint is an awesome project, happy to contribute! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

False positive builtin-not-iterating when using map()
3 participants
@tiagohonorato @coveralls @Pierre-Sassoulas