Fix false positive when map() receives iterable

Since map() supports iterables, it should not issue builtin-not-iterating for iterable arguments. Signed-off-by: Tiago Honorato <tiagohonorato1@gmail.com>
pylint-dev · Feb 20, 2021 · 419d23f · 419d23f
1 parent ba6a403
commit 419d23f
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 2 deletions.
diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt
@@ -445,3 +445,5 @@ contributors:
 * Marc Mueller (cdce8p): contributor
 
 * David Gilman: contributor
+
+* Tiago Honorato: contributor
diff --git a/ChangeLog b/ChangeLog
@@ -5,6 +5,10 @@ Pylint's ChangeLog
 What's New in Pylint 2.7.0?
 ===========================
 
+* Fix false positive for ``builtin-not-iterating`` when ``map`` receives iterable
+
+  Closes #4078
+
 * Python 3.6+ is now required.
 
 * Fix false positive for ``builtin-not-iterating`` when ``zip`` receives iterable

diff --git a/doc/whatsnew/2.7.rst b/doc/whatsnew/2.7.rst
@@ -29,7 +29,7 @@ New checkers
 Other Changes
 =============
 
-* Fix false positive for ``builtin-not-iterating`` when ``zip`` receives iterable
+* Fix false positive for ``builtin-not-iterating`` when ``zip`` or ``map`` receives iterable
 
 * Fix linter multiprocessing pool shutdown which triggered warnings when runned in parallels with other pytest plugins.
 

diff --git a/pylint/checkers/python3.py b/pylint/checkers/python3.py
@@ -97,6 +97,7 @@ def _is_builtin(node):
     "frozenset",
     "OrderedDict",
     "zip",
+    "map",
 }
 ATTRIBUTES_ACCEPTS_ITERATOR = {"join", "from_iterable"}
 _BUILTIN_METHOD_ACCEPTS_ITERATOR = {

diff --git a/tests/checkers/unittest_python3.py b/tests/checkers/unittest_python3.py
@@ -187,6 +187,11 @@ def as_argument_to_zip_test(self, fxn):
         with self.assertNoMessages():
             self.walk(module)
 
+    def as_argument_to_map_test(self, fxn):
+        module = astroid.parse(f"list(map(__, {fxn}()))")
+        with self.assertNoMessages():
+            self.walk(module)
+
     def as_iterable_in_unpacking(self, fxn):
         node = astroid.extract_node(
             f"""
@@ -224,7 +229,7 @@ def iterating_context_tests(self, fxn):
         self.as_iterable_in_starred_context(fxn)
         self.as_argument_to_itertools_functions(fxn)
         self.as_argument_to_zip_test(fxn)
-
+        self.as_argument_to_map_test(fxn)
         for func in (
             "iter",
             "list",