Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bad whitespace from the codebase #3577

Merged
merged 5 commits into from May 3, 2020
Merged

Remove bad whitespace from the codebase #3577

merged 5 commits into from May 3, 2020

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented May 2, 2020 •
edited

Description

As discussed in #3512. Reading #1368 makes me wonder if we should also remove most of the options in "no-space-check"? It would remove more code but I think we would nuke how trailing-whitespace can be used to disallow empty line in the process? We could also take a new look to maybe close #1110. (ie : We're keeping the low effort formatter check, but are we adding new one?)

Type of Changes

Type
✓ 🔨 Refactoring
✓ 📜 Docs

Related Issue

Closes #246, #2041, could affect #1368 ?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 90.267% when pulling 962e8b7 on Pierre-Sassoulas:remove-bad-whitespace into 7885d56 on PyCQA:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 90.267% when pulling 962e8b7 on Pierre-Sassoulas:remove-bad-whitespace into 7885d56 on PyCQA:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 90.267% when pulling 962e8b7 on Pierre-Sassoulas:remove-bad-whitespace into 7885d56 on PyCQA:master.

@coveralls
Copy link

coveralls commented May 2, 2020 •
edited

Coverage Status

Coverage decreased (-0.08%) to 90.254% when pulling 5d68c21 on Pierre-Sassoulas:remove-bad-whitespace into 7885d56 on PyCQA:master.

PCManticore
PCManticore approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@PCManticore PCManticore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for 🔥 this code away. Regarding your question, I believe we should also take a look at closing #1110 and the empty line in no-space-check can be removed as well.

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the remove-bad-whitespace branch 2 times, most recently from d89730b to b1e7a90 Compare May 3, 2020 08:15
@Pierre-Sassoulas Pierre-Sassoulas merged commit 0a7a4d4 into pylint-dev:master May 3, 2020
@Pierre-Sassoulas Pierre-Sassoulas linked an issue May 3, 2020 that may be closed by this pull request
Remove bad-whitespace from the codebase #3572
Closed
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 3, 2020
Closed
@Pierre-Sassoulas Pierre-Sassoulas deleted the remove-bad-whitespace branch May 3, 2020 09:03
@Alchemy-Meister Alchemy-Meister mentioned this pull request Mar 30, 2021
Closed
@jacobtylerwalls jacobtylerwalls mentioned this pull request Mar 29, 2022
Closed
khanabid20 added a commit to khanabid20/python-web-app-cicd that referenced this pull request Jun 8, 2022
@khanabid20
Fix for --disable C0326
649d5ce 
Error:

Command line:1:0: R0022: Useless option value for '--disable', 'C0326' was removed from pylint, see pylint-dev/pylint#3577. (useless-option-value)
seebi added a commit to eccenca/cmem-plugin-template that referenced this pull request Jun 9, 2022
@seebi
remove Useless option values
f4c5e26 
'C0326' was removed from pylint, see pylint-dev/pylint#3577
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Jul 3, 2022
Open
@tigattack tigattack mentioned this pull request Oct 11, 2022
Merged
3 tasks
rpatterson added a commit to rpatterson/project-structure that referenced this pull request Nov 6, 2022
@rpatterson
style(pylint): Update PyLint match Black's defaults
5ddbdf5 
Addresses the following linter errors:

    pyproject.toml:1:0: R0022: Useless option value for '--disable', 'C0330' was removed from pylint, see pylint-dev/pylint#3571. (useless-option-value)
    pyproject.toml:1:0: R0022: Useless option value for '--disable', 'C0326' was removed from pylint, see pylint-dev/pylint#3577. (useless-option-value)
jdtournier added a commit to MRtrix3/mrtrix3 that referenced this pull request Nov 15, 2022
@jdtournier
pylint: remove unused or outdated options
8d53707 
Specifically, remove the options mentioned in the log:

testing/pylint.rc:1:0: E0015: Unrecognized option found: argument-name-hint, attr-name-hint, class-attribute-name-hint, class-name-hint, const-name-hint, function-name-hint, inlinevar-name-hint, method-name-hint, module-name-hint, variable-name-hint, no-space-check (unrecognized-option)
testing/pylint.rc:1:0: R0022: Useless option value for '--disable', 'bad-whitespace' was removed from pylint, see pylint-dev/pylint#3577. (useless-option-value)
gnomesysadmins pushed a commit to GNOME/totem that referenced this pull request Dec 5, 2022
@hadess
plugins: Remove ignore for removed pylint checker
a06881e 
Command line:1:0: R0022: Useless option value for '-d', 'C0326' was removed from pylint, see pylint-dev/pylint#3577. (useless-option-value)
clebergnu added a commit to clebergnu/avocado that referenced this pull request Jan 25, 2023
@clebergnu
Drops checks that were removed in latest pylint
15eac38 
This addresses the following:

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0326'
   was removed from pylint, see
   pylint-dev/pylint#3577. (useless-option-value)

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0330'
   was removed from pylint, see
   pylint-dev/pylint#3571. (useless-option-value)

Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu added a commit to clebergnu/avocado that referenced this pull request Jan 26, 2023
@clebergnu
Drops checks that were removed in latest pylint
74737a6 
This addresses the following:

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0326'
   was removed from pylint, see
   pylint-dev/pylint#3577. (useless-option-value)

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0330'
   was removed from pylint, see
   pylint-dev/pylint#3571. (useless-option-value)

Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu added a commit to clebergnu/avocado that referenced this pull request Jan 26, 2023
@clebergnu
Drops checks that were removed in latest pylint
6ac3c7b 
This addresses the following:

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0326'
   was removed from pylint, see
   pylint-dev/pylint#3577. (useless-option-value)

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0330'
   was removed from pylint, see
   pylint-dev/pylint#3571. (useless-option-value)

Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu added a commit to clebergnu/avocado that referenced this pull request Jan 26, 2023
@clebergnu
Drops checks that were removed in latest pylint
cecf7ea 
This addresses the following:

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0326'
   was removed from pylint, see
   pylint-dev/pylint#3577. (useless-option-value)

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0330'
   was removed from pylint, see
   pylint-dev/pylint#3571. (useless-option-value)

Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu added a commit to clebergnu/avocado that referenced this pull request Feb 1, 2023
@clebergnu
Drops checks that were removed in latest pylint
d65d9d6 
This addresses the following:

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0326'
   was removed from pylint, see
   pylint-dev/pylint#3577. (useless-option-value)

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0330'
   was removed from pylint, see
   pylint-dev/pylint#3571. (useless-option-value)

Signed-off-by: Cleber Rosa <crosa@redhat.com>
gnomesysadmins pushed a commit to GNOME/totem that referenced this pull request Feb 13, 2023
@hadess
plugins: Remove ignore for removed pylint checker
383d6b2 
Command line:1:0: R0022: Useless option value for '-d', 'C0326' was removed from pylint, see pylint-dev/pylint#3577. (useless-option-value)
maramsmurthy pushed a commit to maramsmurthy/avocado that referenced this pull request Sep 6, 2023
@clebergnu @maramsmurthy
Drops checks that were removed in latest pylint
7ab01f7 
This addresses the following:

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0326'
   was removed from pylint, see
   pylint-dev/pylint#3577. (useless-option-value)

   .pylintrc:1:0: R0022: Useless option value for '--disable', 'C0330'
   was removed from pylint, see
   pylint-dev/pylint#3571. (useless-option-value)

Signed-off-by: Cleber Rosa <crosa@redhat.com>
gertvdijk added a commit to gertvdijk/crc that referenced this pull request Sep 28, 2023
@gertvdijk
Remove now useless pylint suppressions of C0326 and C0330
495d076 
Fixes pylint meta-errors R0022 'useless-option-value':

    pyproject.toml:1:0: R0022: Useless option value for '--disable',
    'C0330' was removed from pylint, see
    pylint-dev/pylint#3571.
    (useless-option-value)

    pyproject.toml:1:0: R0022: Useless option value for '--disable',
    'C0326' was removed from pylint, see
    pylint-dev/pylint#3577.
    (useless-option-value)
gertvdijk added a commit to gertvdijk/crc that referenced this pull request Sep 30, 2023
@gertvdijk
Remove now useless pylint suppressions of C0326 and C0330
9585f5e 
Fixes pylint meta-errors R0022 'useless-option-value':

    pyproject.toml:1:0: R0022: Useless option value for '--disable',
    'C0330' was removed from pylint, see
    pylint-dev/pylint#3571.
    (useless-option-value)

    pyproject.toml:1:0: R0022: Useless option value for '--disable',
    'C0326' was removed from pylint, see
    pylint-dev/pylint#3577.
    (useless-option-value)
gertvdijk added a commit to gertvdijk/crc that referenced this pull request Sep 30, 2023
@gertvdijk
Remove now useless pylint suppressions of C0326 and C0330
6b08635 
Fixes pylint meta-errors R0022 'useless-option-value':

    pyproject.toml:1:0: R0022: Useless option value for '--disable',
    'C0330' was removed from pylint, see
    pylint-dev/pylint#3571.
    (useless-option-value)

    pyproject.toml:1:0: R0022: Useless option value for '--disable',
    'C0326' was removed from pylint, see
    pylint-dev/pylint#3577.
    (useless-option-value)
Nicoretti pushed a commit to Nicoretti/crc that referenced this pull request Oct 1, 2023
@gertvdijk @Nicoretti
Remove now useless pylint suppressions of C0326 and C0330
3fee410 
Fixes pylint meta-errors R0022 'useless-option-value':

    pyproject.toml:1:0: R0022: Useless option value for '--disable',
    'C0330' was removed from pylint, see
    pylint-dev/pylint#3571.
    (useless-option-value)

    pyproject.toml:1:0: R0022: Useless option value for '--disable',
    'C0326' was removed from pylint, see
    pylint-dev/pylint#3577.
    (useless-option-value)
shailshouryya added a commit to shailshouryya/yt-videos-list that referenced this pull request Nov 16, 2023
@shailshouryya
Update disable values no longer required in pylint==3.0.2
aae0dd6 
- addresses the following `pylint` warnings:

```
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'C0326' was removed from pylint, see pylint-dev/pylint#3577. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'print-statement' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'parameter-unpacking' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'unpacking-in-except' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'old-raise-syntax' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'backtick' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'import-star-module-level' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'apply-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'basestring-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'buffer-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'cmp-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'coerce-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'execfile-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'file-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'long-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'raw_input-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'reduce-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'standarderror-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'unicode-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'xrange-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'coerce-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'delslice-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'getslice-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'setslice-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'no-absolute-import' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'old-division' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'dict-iter-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'dict-view-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'next-method-called' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'metaclass-assignment' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'indexing-exception' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'raising-string' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'reload-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'oct-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'hex-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'nonzero-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'cmp-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'input-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'round-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'intern-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'unichr-builtin' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'map-builtin-not-iterating' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'zip-builtin-not-iterating' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'range-builtin-not-iterating' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'filter-builtin-not-iterating' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'using-cmp-argument' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'div-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'idiv-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'rdiv-method' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'exception-message-attribute' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'invalid-str-codec' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'sys-max-int' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'bad-python3-import' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'deprecated-string-function' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'deprecated-str-translate-call' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'deprecated-itertools-function' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'deprecated-types-field' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'next-method-defined' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'dict-items-not-iterating' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'dict-keys-not-iterating' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'dict-values-not-iterating' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'deprecated-operator-function' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'deprecated-urllib-function' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'xreadlines-attribute' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'deprecated-sys-function' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'exception-escape' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: R0022: Useless option value for '--disable', 'comprehension-escape' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value)
python/.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'long-suffix' (unknown-option-value)
python/.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'old-ne-operator' (unknown-option-value)
python/.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'old-octal-literal' (unknown-option-value)
python/.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'non-ascii-bytes-literal' (unknown-option-value)
python/.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'eq-without-hash' (unknown-option-value)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PCManticore PCManticore PCManticore approved these changes

@AWhetter AWhetter Awaiting requested review from AWhetter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Pierre-Sassoulas @coveralls @PCManticore