Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hooks: matplotlib: assert that mpl_data_dir is not empty #5629

Merged
merged 2 commits into from Mar 13, 2021
Merged

hooks: matplotlib: assert that mpl_data_dir is not empty #5629

merged 2 commits into from Mar 13, 2021

Commits on Mar 12, 2021

  1. hooks: matplotlib: assert that mpl_data_dir is not empty 

    If the statement in exec_statement() fails for whatever reason,
mpl_data_dir ends up empty, which in turn cases the current working
directory being collected as matplotlib/mpl-data.

This leads to difficult-to-debug issues (see confusion around .git
directory under pyinstaller#5504), so it's better to just signal the error.
    @rokm
    rokm committed Mar 12, 2021
    Copy the full SHA
    f3d48be View commit details
    Browse the repository at this point in the history

  2. tests: pin matplotlib to version 3.3.4

    @rokm
    rokm committed Mar 12, 2021
    Copy the full SHA
    90a5a38 View commit details
    Browse the repository at this point in the history