New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hooks: matplotlib: assert that mpl_data_dir is not empty #5629
hooks: matplotlib: assert that mpl_data_dir is not empty #5629
Conversation
If the statement in exec_statement() fails for whatever reason, mpl_data_dir ends up empty, which in turn cases the current working directory being collected as matplotlib/mpl-data. This leads to difficult-to-debug issues (see confusion around .git directory under pyinstaller#5504), so it's better to just signal the error.
dabd9d7
to
f3d48be
Compare
Hmm, looks like there's something washed up by this. I notice that this failing job is the only one that installs matplotlib from source. |
Ah, so it's building it from source. The test itself ends up with empty
Search results for So this should probably go away if we pin |
Or maybe if we get the CI to install pinned version of |
Ughh pypa/pip#9542 looks hellish. I'd rather just re-pin matplotlib? |
You're right. Re-pinning matplotlib to 3.3.4 should probably also do the trick as it has wheels for all python versions against which we test. I'll push a commit once AppVeyor finishes its current round. |
✅ Build pyinstaller 1.0.965 completed (commit c137ed5a81 by @rokm) |
Yipee it worked! |
If the statement in
exec_statement()
fails for whatever reason,mpl_data_dir
ends up empty, which in turn cases the current working directory being collected asmatplotlib/mpl-data
.This leads to difficult-to-debug issues (see confusion around
.git
directory under #5504), so it's better to just signal the error.