Setup: Fix unicode path related installation errors (#5678). #5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pip prefers to install sdists by building a .whl then installing that. If the `wheel` package is not installed then it defaults to the older `python setup.py install` method. This older method breaks if it encounters unicode paths so ideally we want to `wheel` installed before attempting to install PyInstaller itself. PEP517's build-system.requires adds this option. Prevents errors like pyinstaller#5670.
rokm
approved these changes
Mar 29, 2021
BoboTiG
approved these changes
Mar 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pip prefers to install sdists by building a .whl then installing that. If the
wheelpackage is not installed then it defaults to the olderpython setup.py installmethod. This older method breaks if it encounters unicode paths so ideally we want towheelinstalled before attempting to install PyInstaller itself. PEP517's build-system.requires adds this option.One downside of this is that it makes source installations slower because it creates a full blown virtual environment to build this wheel in - even if you already have wheel installed. Another interesting caveat is that it doesn't change
pip install -e ..