Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup: Fix unicode path related installation errors (#5678). #5678

Merged
merged 1 commit into from Mar 30, 2021
Merged

Setup: Fix unicode path related installation errors (#5678). #5678

merged 1 commit into from Mar 30, 2021

Commits on Mar 29, 2021

  1. Setup: Fix unicode path related installation errors (pyinstaller#5678). 

    Pip prefers to install sdists by building a .whl then
installing that. If the `wheel` package is not installed
then it defaults to the older `python setup.py install`
method. This older method breaks if it encounters unicode
paths so ideally we want to `wheel` installed before
attempting to install PyInstaller itself. PEP517's
build-system.requires adds this option.

Prevents errors like pyinstaller#5670.
    @bwoodsend
    bwoodsend committed Mar 29, 2021
    Copy the full SHA
    c493e91 View commit details
    Browse the repository at this point in the history