Setup: Fix unicode path related installation errors (#5678).

Pip prefers to install sdists by building a .whl then installing that. If the `wheel` package is not installed then it defaults to the older `python setup.py install` method. This older method breaks if it encounters unicode paths so ideally we want to `wheel` installed before attempting to install PyInstaller itself. PEP517's build-system.requires adds this option. Prevents errors like #5670.
pyinstaller · Mar 30, 2021 · 6df79e6 · 6df79e6
1 parent d71a9ff
commit 6df79e6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/news/5678.bugfix.rst b/news/5678.bugfix.rst
@@ -0,0 +1,2 @@
+Fix installation issues stemming from unicode characters in
+file paths.
diff --git a/pyproject.toml b/pyproject.toml
@@ -64,3 +64,13 @@
 		directory = "build"
 		name = "Bootloader build"
 		showcontent = true
+
+[build-system]
+# Tells pip to install wheel before trying to install PyInstaller
+# from an sdist or from Github.
+# Installing without wheel uses legacy `python setup.py install`
+# which has issues with unicode paths.
+requires = [
+	"wheel",
+	"setuptools",
+]