Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve display of table in the nbsphinx context #954

Merged
merged 3 commits into from Oct 2, 2022

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Sep 27, 2022

Fix #933

I force the table-layout to auto when the table is nested in a .html_render class
I updated the width of the pandas exampe to check to display

@taylorm0192, @JoerivanEngelen, @jesnie could you confirm that it solves the issue from you side as well ? I cheked the example you gave and the classes embedding the table were quite different than ours.

@12rambau 12rambau marked this pull request as draft September 27, 2022 18:26
@12rambau 12rambau marked this pull request as ready for review September 27, 2022 18:54
@jarrodmillman jarrodmillman added this to the 0.11 milestone Sep 28, 2022
@jarrodmillman jarrodmillman mentioned this pull request Sep 28, 2022
@jarrodmillman
Copy link
Collaborator

Is it possible for us to produce an example that shows the issue? In #958, I cherry-picked f24e6ee and 5a36dc5. To me both tables look fine.

With 9c74db8, the table looks like
954

Without 9c74db8, the table looks like
958

@choldgraf
Copy link
Collaborator

I don't think it's possible for us to use nbsphinx in our docs without disabling MyST-NB 🤔. Im +1 on merge once others confirm their bug is gone.

@jarrodmillman
Copy link
Collaborator

jarrodmillman commented Oct 2, 2022

It may be worth merging this and releasing 0.11rc1 soon. A release candidate may make it easier for folks to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas dataframe columns rendered using nbsphinx don't flex with pydata-sphinx-theme 0.10.1 (scrunched output)
3 participants