FIX: table width of nbsphinx dataframes #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this works for @seanlaw then I saw we just merge it in and can keep iterating if folks report more bugs in the future 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1017
I though initially that the problem was solved by #954, but it wasn't. nbsphinx is not a very nice neighbour as it's injecting its css within the
articletag instead of the header. giving it a super high priority over custom and/or our theme css.Instead of setting an
!importantstatement I simply copy/pasted the complete selector +htmlmaking it more specific and thus giving it the priority.We cannot test it in our theme documentation as we are using mystNB but @seanlaw confirmed it worked from his side.