Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[switcher] default activeVersion and activeVersionName values #654

Merged
merged 3 commits into from May 6, 2022
Merged

[switcher] default activeVersion and activeVersionName values #654

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7c804a
Default activeVersion and activeVersionName
tupui May 5, 2022
a469c1c
Update src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/v…
tupui May 6, 2022
301cd5b
Update src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/v…
tupui May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html
View file
Open in desktop
Expand Up @@ -39,6 +39,9 @@
(function () {
$.getJSON("{{ theme_switcher.get('json_url') }}", function(data, textStatus, jqXHR) {
const currentFilePath = "{{ pagename }}.html";
let btn = document.getElementById("version_switcher_button");
btn.dataset["activeVersionName"] = "";
tupui marked this conversation as resolved.
Show resolved Hide resolved
btn.dataset["activeVersion"] = "";
// create links to the corresponding page in the other docs versions
$.each(data, function(index, entry) {
// if no custom name specified (e.g., "latest"), use version string
Expand Down Expand Up @@ -66,7 +69,6 @@
// version's entry
if (entry.version == "{{ theme_switcher.get('version_match') }}") {
node.classList.add("active");
let btn = document.getElementById("version_switcher_button");
btn.innerText = btn.dataset["activeVersionName"] = entry.name;
btn.dataset["activeVersion"] = entry.version;
}
Expand Down