[switcher] default activeVersion and activeVersionName values
#654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
reviewed
May 6, 2022
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html
Show resolved
Hide resolved
…ersion-switcher.html Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
choldgraf
reviewed
May 6, 2022
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html
Outdated
Show resolved
Hide resolved
…ersion-switcher.html Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
choldgraf
approved these changes
May 6, 2022
choldgraf
changed the title
activeVersion and activeVersionName for version switcheractiveVersion and activeVersionName values
|
Thank you Chris 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PRs, I find it handy to have the PR indicator as the version name in the switcher.
But then, because there is no entry in the json, the button is missing the dataset attributes
activeVersionandactiveVersionName. This PR adds a default empty string (and from codes I could see, this seems to be standard).This would allow to have access to an empty dataset attribute and use it as CSS selector.
Use case in NumPy here: numpy/numpy#21451
And I would do the same for SciPy if this behaviour is confirmed 😃