Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dataclasses docs #6470
Update Dataclasses docs #6470
Changes from 2 commits
72fcb85
ec42a00
9582692
a9ed29e
9c9d398
0401dd3
5edc16e
cd28ad0
1d41a2c
edfc57f
2af8c61
c1766c0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tpdorsey! Could you help me understand what you meant by this diff? It looks to me like the current support for
extra="allow"
is the same as it was after #2557 (the PR where the removed copy was introduced), but I'm wondering if I'm missing something.With
extra="allow"
, extra values passed to__init__
still end up in the instantiated object, but just aren't surfaced via__str__
. Example script:This script yields the following output when running with the latest
pydantic==2.3.0
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Could you please make an issue or ask this in a GitHub discussion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response, @hramezani — opened #7362 to discuss.