New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dataclasses docs #6470
Merged
Merged
Update Dataclasses docs #6470
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
72fcb85
dataclasses and typeadapter
tpdorsey ec42a00
add changes file
tpdorsey 9582692
Apply suggestions from code review
tpdorsey a9ed29e
Apply suggestions from code review
tpdorsey 9c9d398
remove update warning
tpdorsey 0401dd3
Merge branch 'dataclass-docs' of https://github.com/pydantic/pydantic…
tpdorsey 5edc16e
revisions based on feedback
tpdorsey cd28ad0
fix typo
tpdorsey 1d41a2c
Apply suggestions from code review
tpdorsey edfc57f
Merge branch 'main' into dataclass-docs
tpdorsey 2af8c61
Merge branch 'dataclass-docs' of https://github.com/pydantic/pydantic…
tpdorsey c1766c0
format fixed
tpdorsey File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Docs: document new dataclases features, add links to TypeAdapter documentation. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tpdorsey! Could you help me understand what you meant by this diff? It looks to me like the current support for
extra="allow"
is the same as it was after #2557 (the PR where the removed copy was introduced), but I'm wondering if I'm missing something.With
extra="allow"
, extra values passed to__init__
still end up in the instantiated object, but just aren't surfaced via__str__
. Example script:This script yields the following output when running with the latest
pydantic==2.3.0
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Could you please make an issue or ask this in a GitHub discussion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response, @hramezani — opened #7362 to discuss.