Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with empty dataclass inheritance #4576

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/4576-dolfinus.md
@@ -0,0 +1 @@
Fix `@pydantic.dataclasses.dataclass()` syntax failure on inheriting dataclass without changing fields list
2 changes: 1 addition & 1 deletion pydantic/dataclasses.py
Expand Up @@ -197,7 +197,7 @@ def dataclass(
def wrap(cls: Type[Any]) -> 'DataclassClassOrWrapper':
import dataclasses

if is_builtin_dataclass(cls) and _extra_dc_args(_cls) == _extra_dc_args(_cls.__bases__[0]): # type: ignore
if is_builtin_dataclass(cls) and _extra_dc_args(cls) == _extra_dc_args(cls.__bases__[0]):
dc_cls_doc = ''
dc_cls = DataclassProxy(cls)
default_validate_on_init = False
Expand Down
23 changes: 23 additions & 0 deletions tests/test_dataclasses.py
Expand Up @@ -1472,3 +1472,26 @@ def __post_init__(self):
self.a *= 3

assert C().a == 6 # 1 * 3 + 3


def test_issue_4565():
@dataclasses.dataclass
class A:
a: int = 1

# both @decorator and @decorator() syntax shold be okay
@pydantic.dataclasses.dataclass
class B(A):
b: int = 2

@pydantic.dataclasses.dataclass
class C(A):
...

@pydantic.dataclasses.dataclass()
class BB(A):
bb: int = 2

@pydantic.dataclasses.dataclass()
class CC(A):
...