New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error with empty dataclass inheritance #4576
Conversation
@PrettyWood could you take a look at this? |
Does it fix all new tests related to dataclasses or just one? |
Also @dolfinus please include a descriptive PR title and don't include issue ids in titles. |
Failing test for FastAPI is not linked to this PR, the same check is failing on 1.10x-fixes branch |
Any updates? |
This seems fine to me, @PrettyWood are you happy to accept this? |
This affects the same line discussed on #4498, but doesn't appear to fix the problem. @PrettyWood do you have any idea if there's an easy way to fix both #4498 and #4565? |
I understand that, but the line changed here is the same line discussed in #4498. Obviously before we release v1.10.3, we need to fix both issues. Hence I'm trying work out a fix that covers both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks! |
Fix
@pydantic.dataclasses.dataclass()
syntax failure on inheriting dataclass without changing fields list.Closes #4565