Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
As described in the issue, #4458 was double encoding URLs, this splits the URL on encoding groups with the regex
(.*?)(%[\dA-F]{2})
to (hopefully) fix the issue.Changes:
foo%2Bbar
is left unchanged whilefoo%2bbar
is converted tofoo%2Bbar
/
is no longer encoded in query paramters, e.g.http://example.com?a=b/c
is left unchangedRelated issue number
fix #4458
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change