Bugfix/anyurl escapes percent sign in url

[vetedde]

Change Summary

Fix re-quote when build url. I added relevant cases to test.
Also fix mypy error, because without it I couldn't create commit

Related issue number

Fix #4458

Checklist

• Unit tests for the changes exist
• Tests pass on CI and coverage remains at 100%
• Documentation reflects the changes where applicable
• changes/<pull request or issue id>-<github username>.md file added describing change
  (see changes/README.md for details.
  You can skip this check if the change does not need a change file.)
• [] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

[hramezani]

Please add tests for your change into test_build_url_quote_plus

[hramezani]

Thanks @vetedde for this patch 👍
I left some comments. please update

[hramezani]

please compile the pattern and then use the match on the compiled pattern.
Take a look at the same implementation in datetime_parse.py

pydantic/pydantic/datetime_parse.py

Line 30 in 32ea885

date_re = re.compile(f'{date_expr}$')

[samuelcolvin]

Can you add a comment explaining what this regex is doing?

I also think it could be simplified.

[vetedde]

Regex checks that string contains only %xx or A-Za-z0-9 and _ and nothing else.
Pattern work with cases: http://regexr.com/6t6g6

[vetedde]

@hramezani found a problem with case "foo%20bar", when quote_plus is True. My solution returns foo%20bar, but need foo+bar. I'm thinking of adding an extra check, but it's nested check and still have to unquote at some point

string_with_precent_code_re = re.compile(r'^([\w]+|(%\d{2}))+$')

if string_with_precent_code_re.match(string) is not None:
    if cls.quote_plus:
        string = unquote_plus(string)
    else:
        return string

return quote_plus(string, safe) if cls.quote_plus else quote(string, safe)

Maybe it's better to do it at once:

string = unquote_plus(string, safe) if cls.quote_plus else unquote(string, safe)
return quote_plus(string, safe) if cls.quote_plus else quote(string, safe)

or always do unquote if match %xx

What do you think?

[hramezani]

@vetedde I think there are 3 possible solutions:

1. unquote string in any case and then quote it
2. unquote string if it is already quoted(checking by regex for example) and then quote it
3. revert this feature because seems it is complex and is not good performance-wise (we need to unquote and then quote)

What do you think @samuelcolvin

[samuelcolvin]

please have a look at #4469, I think it's a cleaner approach to solve this. I've also added a large number of test cases to at least lock the behaviour. I'll reply on the original issue with some more context.

Thanks so much @vetedde for looking into this, I'll leave this PR open in case it is decided that it's a better approach than #4469.

[hramezani]

I think we still will have the problem reported in #4468 even with this patch. which is a breaking change.

[samuelcolvin]

After some consideration and discussions, I've decided to replace this by #4470. @vetedde thanks again for your contribution.

See #4470 for a full explanation.