Fix BaseModel.__repr__ with extra fields #3324
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Consider this example:
Latest pydantic master branch would crash with
Pydantic
1.8.2
works fine and this is a regression after 362f4a5 .This commit makes sure we only try to access defined fields.
As a side effect this means extra fields do not get into model representation.
I'm not sure if that's the expected behavior though.
Related issue number
#3234
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)