#3234 exclude extra field when represent model #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
|
I thought it was right to exclude "extra field". Let me know if I'm thinking in a different direction from main |
samuelcolvin
reviewed
Dec 8, 2021
|
please update. |
5 tasks
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
|
updated |
|
HI @COCOLMAN you seem to have prevented me from contributing to your PR which means I can't fix the small issue in tests. Please accept this change. In future it would be easier if you gave permissions to maintainers to contribute to your pull requests for situations exactly like this. |
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
|
Thx. I will check |
|
Thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
has been modified to exclude unpredictable "extra" fields from "repr"
Related issue number
fix #3234
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)