Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forward ref with nested models and optional fields #1752

Merged
merged 2 commits into from
Oct 8, 2020
Merged

fix: forward ref with nested models and optional fields #1752

merged 2 commits into from
Oct 8, 2020

Commits on Jul 22, 2020

  1. fix: forward ref with nested models and optional fields 

    PR pydantic#1712 introduced a regression for forward refs in `ModelField.prepare`
as it would not return early for forward refs anymore.
Optional fields would hence have `required` set to `True`.

closes pydantic#1736
    @PrettyWood
    PrettyWood committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    6961567 View commit details
    Browse the repository at this point in the history

  2. test: skip python 3.6 as __future__.annotations is not defined

    @PrettyWood
    PrettyWood committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    fc2b237 View commit details
    Browse the repository at this point in the history