fix: forward ref with nested models and optional fields #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR pydantic#1712 introduced a regression for forward refs in `ModelField.prepare` as it would not return early for forward refs anymore. Optional fields would hence have `required` set to `True`. closes pydantic#1736
Codecov Report
@@ Coverage Diff @@
## master #1752 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3895 3895
Branches 783 783
=========================================
Hits 3895 3895
Continue to review full report at Codecov.
|
|
great, thank you. Sorry it's taken me so long to get to this. Does this need a patch release or can it wait until 1.7? |
|
@samuelcolvin I guess it can wait as no issue has been opened since then for this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
PR #1712 introduced a regression for forward refs in
ModelField.prepareas it would not return early for forward refs anymore.
Optional fields would hence have
requiredset toTrue.Related issue number
closes #1736
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)