Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass validator each item docs #1592

Merged

Conversation

samueldeklund
Copy link
Contributor

@samueldeklund samueldeklund commented Jun 3, 2020

Change Summary

Subclass validators do not run when referencing a List field defined in a parent class when each_item=True. Added an example to the docs illustrating this.

Related issue number

#1566

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #1592 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1592   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3796      3796           
  Branches       752       752           
=========================================
  Hits          3796      3796           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e82689...37e2a1a. Read the comment docs.

@samueldeklund
Copy link
Contributor Author

@samuelcolvin Not sure if there is anything left for me to do. If so, please let me know and I will work on it.

@samuelcolvin samuelcolvin merged commit 7bd635c into pydantic:master Jun 27, 2020
@samuelcolvin
Copy link
Member

thanks so much, sorry for the slow response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants