New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed warnings and progrss bar improvements #567
Conversation
Fixed the warnings arising in propensity score estimators and added optional progress bars for refuters Signed-off-by: Amey Varhade <ameyvarhade@gmail.com>
The progress bars have been added; the default is set to False, and the verbose mode from joblib provides updates, but alternatively, this can be used. The warning arising in propensity score estimators, as seen here, is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @yemaedahrav ! Added a few comments. Once you address them, I can merge.
Signed-off-by: Amey Varhade <ameyvarhade@gmail.com>
The changes are in the commit. I also noticed in the build logs that it failed in the dowhy_demo_dummy_outcome_refuter notebook however, I have not made any modifications to the dummy outcome refuter and in the latest release version it works perfectly fine. |
That's okay. Can you push the commit to this branch |
Now, this PR has all the relevant commits |
@yemaedahrav there is a bug in this PR. Can you check? TypeError: refute_estimate() takes 1 positional argument but 2 were given |
Signed-off-by: Amey Varhade <ameyvarhade@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yemaedahrav . This is a very useful addition to track the progress of refutation tests.
@all-contributors please add @yemaedahrav for code. |
I've put up a pull request to add @yemaedahrav! 🎉 |
Fixed the warnings arising in propensity score estimators and added optional progress bars for refuters
Signed-off-by: Amey Varhade ameyvarhade@gmail.com